Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ replace loot-core/src imports with loot-core #4349

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

MatissJanis
Copy link
Member

@MatissJanis MatissJanis commented Feb 10, 2025

Cleanup: removing loot-core/src/* imports in favour of loot-core/*.

This standardisation will also help eventually to move to proper monorepo module resolution via yarn instead of mixing yarn & ts for this.

@actual-github-bot actual-github-bot bot changed the title ♻️ replace loot-core/src imports with loot-core [WIP] ♻️ replace loot-core/src imports with loot-core Feb 10, 2025
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 79fd963
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/67ab92fe4f619f0008eaab15
😎 Deploy Preview https://deploy-preview-4349.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 6.84 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/en-GB.js 99.33 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/de.js 110.85 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/pt-BR.js 106.43 kB 0%
static/js/nl.js 94.83 kB 0%
static/js/wide.js 102.8 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/useAccountPreviewTransactions.js 1.69 kB 0%
static/js/AppliedFilters.js 10.52 kB 0%
static/js/narrow.js 84.94 kB 0%
static/js/en.js 99.43 kB 0%
static/js/uk.js 111.11 kB 0%
static/js/ReportRouter.js 1.59 MB 0%
static/js/index.js 4.29 MB 0%

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.33 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.33 MB 0%

@MatissJanis MatissJanis changed the title [WIP] ♻️ replace loot-core/src imports with loot-core ♻️ replace loot-core/src imports with loot-core Feb 10, 2025
Copy link
Contributor

@matt-fidd matt-fidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds work as intended, and I can't find any occurrences left with ripgrep. LGTM

@matt-fidd
Copy link
Contributor

Can we outlaw this in lint like #4347?

@MatissJanis
Copy link
Member Author

That's the goal @matt-fidd

I'll be following up this PR with more changes for module resolution

@MatissJanis MatissJanis merged commit 7d9190e into master Feb 11, 2025
21 checks passed
@MatissJanis MatissJanis deleted the matiss/loot-core branch February 11, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants