Add an action to automatically generate release PRs #4306
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
jfdoming
changed the title
WalkthroughThe pull request introduces a new Bash script and a GitHub Actions workflow. The Bash script, located in the Suggested labels
Suggested reviewers
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
.github/workflows/generate-release-pr.yml (1)
29-35: Enhance PR creation configuration.Consider adding:
- PR labels for better categorization
- Base branch configuration
- PR template or more detailed description
- name: Create PR uses: peter-evans/create-pull-request@v7 with: commit-message: '🔖 (${{ steps.bump_package_versions.outputs.version }})' title: '🔖 (${{ steps.bump_package_versions.outputs.version }})' - body: 'Generated by [generate-release-pr.yml](../tree/master/.github/workflows/generate-release-pr.yml)' + body: | + ## Release v${{ steps.bump_package_versions.outputs.version }} + + This PR was automatically generated by [generate-release-pr.yml](../tree/master/.github/workflows/generate-release-pr.yml). + + ### Changes + - Bumped version to ${{ steps.bump_package_versions.outputs.version }} + - Updated package.json files + labels: | + release + automated branch: 'release/v${{ steps.bump_package_versions.outputs.version }}' + base: ${{ github.event.inputs.ref }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
upcoming-release-notes/4306.mdis excluded by!**/*.md
📒 Files selected for processing (2)
.github/actions/bump-package-versions(1 hunks).github/workflows/generate-release-pr.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Functional
- GitHub Check: Visual regression
🔇 Additional comments (2)
.github/actions/bump-package-versions (2)
1-1: Add execute permissions to the script.The script needs to be executable to run in the workflow.
Run this command to verify and fix permissions:
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Check if script is executable ls -l .github/actions/bump-package-versions # Make it executable if needed chmod +x .github/actions/bump-package-versionsLength of output: 180
Script execution permissions are correctly set.
The permissions on.github/actions/bump-package-versionsare-rwxr-xr-x, which means it is already executable. No further changes are needed.
13-15: Verify the version calculation logic.The version calculation logic assumes:
- Current versions follow YY.MM.patch format
- Day 25 is the cutoff for patch vs minor version bump
- Month rollover increments year
Please verify these assumptions align with project requirements.
Slowly trying to make the release process easier. To start, I wrote a script+manually-triggered action which will automatically create a release PR for the "next" version and bump all
package.jsonfiles to that version. If you don't specify a version, it infers it using this logic which to me seems to mirror how we already do releases (pseudocode):See this test run which generated jfdoming#5.
I'm thinking eventually we can move the release note generation to this action as well and save an extra round trip with CI! It would also be nice to automatically generate the release docs. One day...