Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow child transactions to have different transfer payees #4255

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

jfdoming
Copy link
Contributor

Fix for an issue reported on Discord. The original issue involved rules with splits, but I found a much simpler repro:

  1. Create a transaction with a transfer payee but don't hit "Add."
  2. Set the category to "Split" and add a single child.
  3. Change the child payee to a different transfer account.
  4. Click "Add."
  5. Observe that the payee on the child in the added transaction is not set.

Looking for input from others with more context on the direction we're taking with payees on parent transactions, but I think this matches the approach we've taken in other places (child transactions are the source of truth, parents are generated based on the children).

Verified

This commit was signed with the committer’s verified signature.
jfdoming Julian Dominguez-Schatz
@actual-github-bot actual-github-bot bot changed the title fix: allow child transactions to have different transfer payees [WIP] fix: allow child transactions to have different transfer payees Jan 29, 2025
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit e4e9c91
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6799bca0797eb60008bbf39a
😎 Deploy Preview https://deploy-preview-4255.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 6.7 MB → 6.7 MB (+338 B) +0.00%
Changeset
File Δ Size
node_modules/clsx/dist/clsx.js 🆕 +509 B 0 B → 509 B
node_modules/clsx/dist/clsx.js?commonjs-module 🆕 +27 B 0 B → 27 B
node_modules/es-define-property/index.js 📈 +210 B (+60.00%) 350 B → 560 B
node_modules/has-property-descriptors/index.js 📈 +9 B (+1.57%) 573 B → 582 B
node_modules/call-bind/index.js 📈 +9 B (+0.85%) 1.04 kB → 1.05 kB
node_modules/define-data-property/index.js 📈 +9 B (+0.39%) 2.24 kB → 2.25 kB
node_modules/react-grid-layout/build/ReactGridLayout.js 📉 -1 B (-0.00%) 24.96 kB → 24.96 kB
node_modules/react-grid-layout/build/GridItem.js 📉 -1 B (-0.00%) 21.49 kB → 21.49 kB
node_modules/react-grid-layout/build/components/WidthProvider.js 📉 -1 B (-0.02%) 5.22 kB → 5.22 kB
node_modules/clsx/dist/clsx.mjs 🔥 -368 B (-100%) 368 B → 0 B
node_modules/clsx/dist/clsx.mjs?commonjs-proxy 🔥 -64 B (-100%) 64 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 4.29 MB → 4.29 MB (+405 B) +0.01%

Smaller

Asset File Size % Changed
static/js/ReportRouter.js 1.59 MB → 1.59 MB (-67 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/en-GB.js 93.42 kB 0%
static/js/pt-BR.js 103.29 kB 0%
static/js/uk.js 111.11 kB 0%
static/js/nl.js 79.76 kB 0%
static/js/en.js 99.34 kB 0%
static/js/narrow.js 84.94 kB 0%
static/js/useAccountPreviewTransactions.js 1.69 kB 0%
static/js/AppliedFilters.js 10.52 kB 0%
static/js/wide.js 102.8 kB 0%

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.33 MB → 1.33 MB (-281 B) -0.02%
Changeset
File Δ Size
packages/loot-core/src/server/accounts/transfer.ts 📉 -1003 B (-15.98%) 6.13 kB → 5.15 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.33 MB → 1.33 MB (-281 B) -0.02%

Unchanged

No assets were unchanged

Verified

This commit was signed with the committer’s verified signature.
jfdoming Julian Dominguez-Schatz
@jfdoming jfdoming added this to the v25.2.0 milestone Jan 29, 2025
@jfdoming jfdoming changed the title [WIP] fix: allow child transactions to have different transfer payees fix: allow child transactions to have different transfer payees Jan 29, 2025
Copy link
Contributor

coderabbitai bot commented Jan 29, 2025

Walkthrough

This pull request introduces changes across multiple files related to transaction handling and testing. In rules.test.ts, a new test case was added to verify the functionality of splitting transactions, specifically checking that a rule can modify the payee of a subtransaction. In transfer.test.ts, a new test was implemented to ensure that split transfers are correctly retained on child transactions, with modifications to the Transaction type to support parent-child transaction relationships. The transfer.ts file saw the removal of code that previously enforced constraints on child transaction transfers, potentially allowing more flexibility in transaction payee assignments.

Possibly related PRs

Suggested labels

sparkles:Merged

Suggested reviewers

  • youngcw
  • matt-fidd

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1c3b9b and e4e9c91.

⛔ Files ignored due to path filters (2)
  • packages/loot-core/src/server/accounts/__snapshots__/transfer.test.ts.snap is excluded by !**/*.snap
  • upcoming-release-notes/4255.md is excluded by !**/*.md
📒 Files selected for processing (3)
  • packages/loot-core/src/server/accounts/rules.test.ts (1 hunks)
  • packages/loot-core/src/server/accounts/transfer.test.ts (2 hunks)
  • packages/loot-core/src/server/accounts/transfer.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/loot-core/src/server/accounts/transfer.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Visual regression
  • GitHub Check: Functional
🔇 Additional comments (3)
packages/loot-core/src/server/accounts/transfer.test.ts (2)

47-49: LGTM! Well-structured type definition.

The new optional properties for managing parent-child relationships are well-named and follow TypeScript conventions.


174-220: LGTM! Comprehensive test coverage for split transaction payees.

The test thoroughly verifies that child transactions can maintain different transfer payees than their parent transactions, which directly addresses the reported issue. The test setup and assertions are clear and comprehensive.

packages/loot-core/src/server/accounts/rules.test.ts (1)

527-550: LGTM! Good test coverage for rule-based payee changes in splits.

The test effectively verifies that rules can modify payees in split transactions, which complements the changes allowing child transactions to have different transfer payees.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sorry, something went wrong.

Copy link
Contributor

@matt-fidd matt-fidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and aligns with the behaviour I'd expect, and the behaviour elsewhere

@jfdoming jfdoming merged commit b09d800 into actualbudget:master Jan 29, 2025
20 checks passed
@jfdoming jfdoming deleted the jfdoming/fix-split-payee-bug branch February 5, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants