Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ♻️ moving test runners from jest to vitest #4212

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MatissJanis
Copy link
Member

@MatissJanis MatissJanis commented Jan 20, 2025

Abandoned: #4212 (comment)

Moving all remaining jest references to vitest.

@actual-github-bot actual-github-bot bot changed the title ♻️ moving test runners from jest to vitest [WIP] ♻️ moving test runners from jest to vitest Jan 20, 2025
Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 80e6492
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6790090e6bb0340008654195
😎 Deploy Preview https://deploy-preview-4212.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 6.69 MB → 6.69 MB (-101 B) -0.00%
Changeset
File Δ Size
node_modules/clsx/dist/clsx.mjs 🆕 +368 B 0 B → 368 B
node_modules/clsx/dist/clsx.mjs?commonjs-proxy 🆕 +64 B 0 B → 64 B
node_modules/react-grid-layout/build/components/WidthProvider.js 📈 +1 B (+0.02%) 5.22 kB → 5.22 kB
node_modules/react-grid-layout/build/GridItem.js 📈 +1 B (+0.00%) 21.49 kB → 21.49 kB
node_modules/react-grid-layout/build/ReactGridLayout.js 📈 +1 B (+0.00%) 24.96 kB → 24.96 kB
node_modules/clsx/dist/clsx.js 🔥 -509 B (-100%) 509 B → 0 B
node_modules/clsx/dist/clsx.js?commonjs-module 🔥 -27 B (-100%) 27 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.59 MB → 1.59 MB (+67 B) +0.00%

Smaller

Asset File Size % Changed
static/js/index.js 4.28 MB → 4.28 MB (-168 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/nl.js 62.88 kB 0%
static/js/en.js 98.94 kB 0%
static/js/en-GB.js 97.97 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/pt-BR.js 108.78 kB 0%
static/js/uk.js 118.39 kB 0%
static/js/useAccountPreviewTransactions.js 1.69 kB 0%
static/js/AppliedFilters.js 10.52 kB 0%
static/js/narrow.js 85.06 kB 0%
static/js/wide.js 101.46 kB 0%

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.33 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.33 MB 0%

@MatissJanis
Copy link
Member Author

Ok, I don't have any further ideas how to make the remaining tests work. There are two distinct problems here for which I don't have a solution. I'll keep the PR open until it goes stale. If anyone is interested to pick this up from me - you're welcome!

The two problems:

  • vitest doesn't seem to be playing well with yarn workspaces (for example sync.test.ts failure in loot-core)
  • vitest does not want to import the wasm sqlite file (see failures in *.web.ts files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant