[WIP] Feature/sankey chart #4156
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
spezzino
force-pushed
the
feature/sankey-chart
branch
from
b5e167c to
fceb57d
Compare
spezzino
force-pushed
the
feature/sankey-chart
branch
from
fceb57d to
8b6d305
Compare
spezzino
force-pushed
the
feature/sankey-chart
branch
from
8b6d305 to
2c834e6
Compare
|
There are a few quirks that Ive seen so far. Strange loopback thing. This only happens on some window sizes and some month ranges. Its fairly consistent on one month windows. Crossover of spending. This was happening in the original sankey stuff and looks to still be around now. |
thanks for your feedback, @youngcw. Would you be able to provide a sample budget for the issues you found? |
|
Looks like we're working towards the same goal: #4142 one thing people were split between is whether to add this under widget types for custom report or a separate standalone report like net worth. What's your thought? |
Im struggling to recreate the issues. Those screenshots came from a demo file. Im able to consistently get that second line crossing issue with my personal budget, but im not able to get that first one again. |
I don't have a preference, however I would like to drive this to completion with the minimum requirements and then iterate over to add more features |
|
👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review. |
| }: SankeyNodeProps) { | ||
| const privacyMode = usePrivacyMode(); | ||
| const isOut = x + width + 6 > containerWidth; | ||
| let payloadValue = Math.round(payload.value / 1000).toString(); |
There was a problem hiding this comment.
this is a bit opinionated and assumes groups will ladder up to at least this amount. Was this done to address a spacing issue?
| /> | ||
| <text | ||
| textAnchor={isOut ? 'end' : 'start'} | ||
| x={isOut ? x - 6 : x + width + 6} |
There was a problem hiding this comment.
6 is a magic number here that needs to match with line 36 and below. Perhaps just create a constant so it is clear for future maintenance
| @@ -0,0 +1,202 @@ | |||
| // @ts-strict-ignore | |||
There was a problem hiding this comment.
curious what this is actually ignoring
Attempt to revive the Sankey Chart (#1919), removed due to it being abandoned.
Enhancements over the previous implementation: