Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Redux Toolkit Migration] notificationsSlice #4126

Open
wants to merge 5 commits into
base: redux-toolkit-modals-slice
Choose a base branch
from

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Jan 10, 2025

@actual-github-bot actual-github-bot bot changed the title [Redux Toolkit Migration] notificationsSlice [WIP] [Redux Toolkit Migration] notificationsSlice Jan 10, 2025
@joel-jeremy joel-jeremy changed the base branch from master to redux-toolkit-budgets-slice January 10, 2025 21:50
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit fa6958b
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/67819672d56e3100084eb6fc
😎 Deploy Preview https://deploy-preview-4126.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joel-jeremy joel-jeremy changed the base branch from redux-toolkit-budgets-slice to master January 10, 2025 21:50
@joel-jeremy joel-jeremy changed the base branch from master to redux-toolkit-modals-slice January 10, 2025 21:52
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 6.71 MB → 6.71 MB (+2.4 kB) +0.03%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/client/notifications/notificationsSlice.ts 🆕 +1.37 kB 0 B → 1.37 kB
src/hooks/useUndo.ts 📈 +88 B (+9.99%) 881 B → 969 B
home/runner/work/actual/actual/packages/loot-core/src/client/store/index.ts 📈 +64 B (+4.09%) 1.53 kB → 1.59 kB
src/components/admin/UserAccess/UserAccessRow.tsx 📈 +144 B (+3.99%) 3.52 kB → 3.66 kB
src/components/ServerContext.tsx 📈 +102 B (+2.63%) 3.79 kB → 3.89 kB
home/runner/work/actual/actual/packages/loot-core/src/client/accounts/accountsSlice.ts 📈 +121 B (+2.33%) 5.07 kB → 5.19 kB
src/global-events.ts 📈 +80 B (+2.31%) 3.38 kB → 3.46 kB
home/runner/work/actual/actual/packages/loot-core/src/client/queries/queriesSlice.ts 📈 +290 B (+2.22%) 12.77 kB → 13.05 kB
src/components/modals/TransferOwnership.tsx 📈 +112 B (+1.71%) 6.38 kB → 6.49 kB
src/components/reports/Overview.tsx 📈 +252 B (+1.66%) 14.8 kB → 15.05 kB
src/components/admin/UserAccess/UserAccess.tsx 📈 +102 B (+1.46%) 6.8 kB → 6.9 kB
src/index.tsx 📈 +16 B (+1.45%) 1.08 kB → 1.09 kB
src/components/modals/EditAccess.tsx 📈 +60 B (+1.27%) 4.6 kB → 4.66 kB
src/components/modals/manager/DuplicateFileModal.tsx 📈 +88 B (+1.19%) 7.23 kB → 7.32 kB
src/components/FinancesApp.tsx 📈 +126 B (+1.06%) 11.59 kB → 11.71 kB
src/components/admin/UserDirectory/UserDirectory.tsx 📈 +102 B (+1.02%) 9.74 kB → 9.83 kB
home/runner/work/actual/actual/packages/loot-core/src/client/shared-listeners.ts 📈 +86 B (+0.93%) 9 kB → 9.08 kB
src/components/reports/reports/CustomReportListCards.tsx 📈 +38 B (+0.86%) 4.32 kB → 4.35 kB
src/components/App.tsx 📈 +52 B (+0.85%) 6 kB → 6.06 kB
src/components/manager/subscribe/OpenIdForm.tsx 📈 +110 B (+0.73%) 14.62 kB → 14.73 kB
src/components/reports/reports/Summary.tsx 📈 +110 B (+0.68%) 15.76 kB → 15.87 kB
src/components/modals/manager/ConfirmChangeDocumentDir.tsx 📈 +38 B (+0.54%) 6.83 kB → 6.87 kB
src/components/reports/reports/NetWorth.tsx 📈 +34 B (+0.51%) 6.5 kB → 6.53 kB
src/components/modals/EditUser.tsx 📈 +60 B (+0.43%) 13.61 kB → 13.67 kB
src/components/budget/index.tsx 📈 +38 B (+0.38%) 9.74 kB → 9.78 kB
src/components/Notifications.tsx 📈 +26 B (+0.36%) 6.97 kB → 7 kB
src/components/reports/reports/CashFlow.tsx 📈 +34 B (+0.36%) 9.29 kB → 9.32 kB
src/components/reports/reports/Calendar.tsx 📈 +76 B (+0.28%) 26.07 kB → 26.14 kB
src/components/reports/reports/Spending.tsx 📈 +34 B (+0.17%) 19.76 kB → 19.79 kB
src/components/mobile/transactions/TransactionList.tsx 📈 +25 B (+0.15%) 16.07 kB → 16.09 kB
src/components/accounts/Account.tsx 📈 +38 B (+0.08%) 46.88 kB → 46.91 kB
src/components/transactions/TransactionsTable.jsx 📈 +42 B (+0.06%) 67.8 kB → 67.84 kB
home/runner/work/actual/actual/packages/loot-core/src/client/modals/modalsSlice.ts 📉 -33 B (-1.56%) 2.06 kB → 2.03 kB
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/index.ts 📉 -27 B (-32.14%) 84 B → 57 B
home/runner/work/actual/actual/packages/loot-core/src/client/constants.ts 📉 -153 B (-35.33%) 433 B → 280 B
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/notifications.ts 🔥 -687 B (-100%) 687 B → 0 B
home/runner/work/actual/actual/packages/loot-core/src/client/actions/notifications.ts 🔥 -630 B (-100%) 630 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 4.29 MB → 4.29 MB (+1.8 kB) +0.04%
static/js/ReportRouter.js 1.59 MB → 1.59 MB (+578 B) +0.03%
static/js/wide.js 102.39 kB → 102.43 kB (+38 B) +0.04%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/en.js 98.94 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/nl.js 62.88 kB 0%
static/js/uk.js 118.39 kB 0%
static/js/en-GB.js 97.97 kB 0%
static/js/pt-BR.js 108.78 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 87.67 kB 0%
static/js/useAccountPreviewTransactions.js 1.69 kB 0%
static/js/AppliedFilters.js 10.58 kB 0%

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.33 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.33 MB 0%

@joel-jeremy joel-jeremy force-pushed the redux-toolkit-modals-slice branch from 7e46bc0 to 956a6fb Compare January 13, 2025 23:03
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-notifications-slice branch from 200b0fc to 2384069 Compare January 13, 2025 23:03
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-modals-slice branch from 956a6fb to 45dc869 Compare January 13, 2025 23:11
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-notifications-slice branch from 2384069 to 5e0cf64 Compare January 13, 2025 23:11
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-modals-slice branch from 45dc869 to 1ed2b52 Compare January 13, 2025 23:25
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-notifications-slice branch from 5e0cf64 to 67df0f6 Compare January 13, 2025 23:25
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-modals-slice branch from 1ed2b52 to 03d1911 Compare January 14, 2025 08:18
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-notifications-slice branch from 67df0f6 to 3de3bba Compare January 14, 2025 08:18
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-modals-slice branch from 03d1911 to 37e41fd Compare January 14, 2025 16:44
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-notifications-slice branch 3 times, most recently from 6c28206 to 49c15a1 Compare January 14, 2025 17:15
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-modals-slice branch from 21abbb0 to 051a63f Compare January 14, 2025 17:50
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-notifications-slice branch 2 times, most recently from 532232b to e1dacf3 Compare January 14, 2025 18:10
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-modals-slice branch from 0378594 to 5863812 Compare January 17, 2025 17:44
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-notifications-slice branch from e1dacf3 to b58a227 Compare January 17, 2025 17:44
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-modals-slice branch from 5863812 to b0aefcb Compare January 17, 2025 19:23
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-notifications-slice branch from b58a227 to 28c5c8f Compare January 17, 2025 19:23
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-modals-slice branch from b0aefcb to 63bcdb8 Compare January 20, 2025 07:10
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-notifications-slice branch 2 times, most recently from 86bbe73 to 6a3d459 Compare January 20, 2025 16:19
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-modals-slice branch from 19d448c to 127f5f9 Compare January 21, 2025 18:50
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-notifications-slice branch from 212e5b8 to 81af87a Compare January 21, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant