Sort SimpleFIN transactions in date order

[matt-fidd]

Fixes #556

Ensures that the client inserts the starting balance transaction in the right place.

To test, set up the test SimpleFIN credentials on an edge server and sync from blank - the starting balance transaction will be at the top. Try again on this build, it'll be in the correct pace at the bottom

[coderabbitai]

Walkthrough

The pull request modifies the src/app-simplefin/app-simplefin.js file to introduce a new sortOrder property for transactions in the getAccountResponse function. This change aims to address transaction sorting issues by creating sorted arrays for booked, pending, and all transactions based on a calculated dateToUse. The sorting mechanism ensures that transactions are ordered consistently, with the sortOrder property determining the sequence. The modification impacts how transactions are processed and returned, potentially resolving inconsistencies in transaction ordering for the SimpleFin integration.

Assessment against linked issues

Objective	Addressed	Explanation
Fix transaction sorting for SimpleFin	✅
Ensure consistent sorting from oldest to newest	✅
Align SimpleFin sorting with goCardless approach	✅

Possibly related PRs

• use SimpleFin pending flag for cleared status #494: Modifies getAccountResponse function in the same file, potentially related to transaction categorization
• fix bug in batch SimpleFIN startDate logic #504: Alters getAccountResponse function, improving transaction handling

Suggested labels

sparkles: Merged

Suggested reviewers

• youngcw

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/app-simplefin/app-simplefin.js (1)

235-247: LGTM! Consider extracting the sort comparator.

The sorting implementation correctly orders transactions by date in descending order. However, to improve maintainability and reusability, consider extracting the sort comparator into a named function.

+  const compareTransactions = (a, b) => b.sortOrder - a.sortOrder;
+
-  const bookedSorted = booked.sort((a, b) => b.sortOrder - a.sortOrder);
-  const pendingSorted = pending.sort((a, b) => b.sortOrder - a.sortOrder);
-  const allSorted = all.sort((a, b) => b.sortOrder - a.sortOrder);
+  const bookedSorted = booked.sort(compareTransactions);
+  const pendingSorted = pending.sort(compareTransactions);
+  const allSorted = all.sort(compareTransactions);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0312f51 and c123f44.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/559.md is excluded by !**/*.md

📒 Files selected for processing (1)

• src/app-simplefin/app-simplefin.js (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Build Docker image (alpine)
• GitHub Check: Build Docker image (ubuntu)

🔇 Additional comments (1)

src/app-simplefin/app-simplefin.js (1)

219-219: LGTM! Good choice using dateToUse for sorting.

The sortOrder property is correctly assigned using the appropriate date field based on the transaction's status (pending vs posted).