Skip to content
This repository has been archived by the owner on Feb 10, 2025. It is now read-only.

Commit

Permalink
add coderabbit fixes to test file
Browse files Browse the repository at this point in the history
  • Loading branch information
DennaGherlyn committed Jan 16, 2025
1 parent d36d396 commit 41e4dbf
Showing 1 changed file with 18 additions and 5 deletions.
23 changes: 18 additions & 5 deletions src/app-gocardless/banks/tests/ssk_dusseldorf_dussdeddxxx.spec.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
import SskDusseldorfDussdeddxxx from '../ssk_dusseldorf_dussdeddxxx.js';

beforeEach(() => {
jest.spyOn(console, 'debug').mockImplementation();
});

afterEach(() => {
jest.restoreAllMocks();
});

describe('#normalizeTransaction', () => {
const bookedTransactionOne = {
transactionId: '2024102900000000-1',
Expand All @@ -12,7 +20,7 @@ describe('#normalizeTransaction', () => {
creditorName: 'a useful creditor name',
remittanceInformationStructured: 'structured information',
remittanceInformationUnstructured: 'unstructured information',
additionalInformation: 'some aditional information',
additionalInformation: 'some additional information',
};

const bookedTransactionTwo = {
Expand All @@ -26,19 +34,19 @@ describe('#normalizeTransaction', () => {
creditorName: 'a useful creditor name',
ultimateCreditor: 'ultimate creditor',
remittanceInformationStructured: 'structured information',
additionalInformation: 'some aditional information',
additionalInformation: 'some additional information',
};

it('properly combines remittance information', () => {
expect(
SskDusseldorfDussdeddxxx.normalizeTransaction(bookedTransactionOne, true)
.remittanceInformationUnstructured,
).toEqual('unstructured information some aditional information');
).toEqual('unstructured information some additional information');

expect(
SskDusseldorfDussdeddxxx.normalizeTransaction(bookedTransactionTwo, true)
.remittanceInformationUnstructured,
).toEqual('structured information some aditional information');
).toEqual('structured information some additional information');
});

it('prioritizes creditor names correctly', () => {
Expand Down Expand Up @@ -67,6 +75,11 @@ describe('#normalizeTransaction', () => {
it('returns null for unbooked transactions', () => {
expect(
SskDusseldorfDussdeddxxx.normalizeTransaction(unbookedTransaction, false),
).toBeNull;
).toBeNull();

expect(console.debug).toHaveBeenCalledWith(
'Skipping unbooked transaction:',
unbookedTransaction.transactionId,
);
});
});

0 comments on commit 41e4dbf

Please sign in to comment.