Bump clang-format to version 18 #613
Conversation
stephenswat
added
cicd
|
This depends on acts-project/machines#106. |
|
I am fine with v18 |
|
Are we also going to update Acts to clang-format-18? 🤔 That one is currently on clang-format-14. (https://github.com/acts-project/acts/blob/main/.github/workflows/checks.yml#L18) So on first order I'd much more prefer to just upgrade to that version in this project as well. Since eventually we'll be importing most of the code from this repository directly into Acts. Which will be a lot easier to do if the formatting already agreed between the two. (Though it may not make much of a difference in the end. Since we'll have to change the naming of all of the classes/functions anyway... 🤔) Other than that, no strong feeling about the specific version that we would use. |
|
Yup, ACTS is also going to v18!
|
The version of clang-format that we use in this project is quite old (version 10) and it is no longer able to properly format all of the new stuff that has come into C++. See, for example, the formatting nightmares in acts-project#609 and acts-project#602. This commit bumps the formatter up to clang-format 18.
|
I think we should also update the following three files:
|
The version of clang-format that we use in this project is quite old (version 10) and it is no longer able to properly format all of the new stuff that has come into C++. See, for example, the formatting nightmares in #609 and #602. This commit bumps the formatter up to clang-format 18.