ref: python cleanup #914
Open
ref: python cleanup #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
added
refactor
niermann999
force-pushed
the
ref-python-cleanup
branch
11 times, most recently
from
2fd05f0 to
355f7b1
Compare
niermann999
added
bug
niermann999
force-pushed
the
ref-python-cleanup
branch
3 times, most recently
from
bea627d to
737ad0e
Compare
|
With these fixes the navigation and material validation works correctly again |
|
stephenswat
approved these changes
Jan 21, 2025
| "_" + | ||
| std::to_string( | ||
| std::ceil(10. * static_cast<double>(pT_range[1])) / 10.) + | ||
| "_GeV"; |
There was a problem hiding this comment.
Is it intended that this will produce very slightly different files names than before?
|
|
||
| const auto data_path{ | ||
| std::filesystem::path{m_cfg.track_param_file()}.parent_path()}; | ||
| const auto truth_trk_path{data_path / (prefix + "truth_track_params_" + | ||
| mometum_str + "GeV.csv")}; | ||
| momentum_str + ".csv")}; |
| @@ -19,7 +19,7 @@ | |||
|
|
|||
|
|
|||
| def __main__(): | |||
| # ----------------------------------------------------------------arg parsing | |||
| # ---------------------------------------------------------------arg parsing | |||
There was a problem hiding this comment.
Any reason for these changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup python plotting code in preparation for benchmark plots:
Fixes a number of small bugs: