ref: Update the config structs #856
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
added
refactor
niermann999
force-pushed
the
ref-better-defaults
branch
3 times, most recently
from
68f8c27
to
76ac65c
Compare
niermann999
changed the title
niermann999
force-pushed
the
ref-better-defaults
branch
from
76ac65c
to
c2c3736
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the navigation config to the ODD/ITk defaults. This should help to use an optimal configuration for the ODD and ITk without passing a specific configuration to detray. Not sure, if there is one configuration that will be optimal for all detectors, though, so the telescope detector needs to be configured explicitly now.
The configuration to the propagation also now have to be passed explicitly, which help not passing the default configuration by mistake.