Split propagate function into client components #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
refactor
stephenswat
force-pushed
the
refactor/split_prop
branch
2 times, most recently
from
72feb61
to
3a620aa
Compare
The current detray code exposes primarily a `propagate` method, but this has an unbounded loop in it. Because callers might want to implement custom load balancing on the stepping process, the current approach may be too coarse. This commit retains the existing `propagate` method but also adds three new component methods, `propagate_init`, `propagate_step`, and `propagate_is_complete` so that client code can more granularly implement their own, load-balanced propagation.
|
niermann999
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current detray code exposes primarily a
propagatemethod, but this has an unbounded loop in it. Because callers might want to implement custom load balancing on the stepping process, the current approach may be too coarse. This commit retains the existingpropagatemethod but also adds three new component methods,propagate_init,propagate_step, andpropagate_is_completeso that client code can more granularly implement their own, load-balanced propagation.