Enable additional conversion warnings

This commit adds some additional floating point conversion warnings in order to bring it in line with the other Acts projects.
acts-project · Jul 25, 2024 · 140bd91 · 140bd91
1 parent 58af063
commit 140bd91
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/cmake/covfie-compiler-options-cpp.cmake b/cmake/covfie-compiler-options-cpp.cmake
@@ -19,6 +19,8 @@ if( ( "${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU" ) OR
    covfie_add_flag( CMAKE_CXX_FLAGS "-Wshadow" )
    covfie_add_flag( CMAKE_CXX_FLAGS "-Wunused-local-typedefs" )
    covfie_add_flag( CMAKE_CXX_FLAGS "-pedantic" )
+   covfie_add_flag( CMAKE_CXX_FLAGS "-Wfloat-conversion" )
+   covfie_add_flag( CMAKE_CXX_FLAGS "-Wconversion" )
 
    # Fail on warnings, if asked for that behaviour.
    if( COVFIE_FAIL_ON_WARNINGS )

diff --git a/cmake/covfie-compiler-options-cuda.cmake b/cmake/covfie-compiler-options-cuda.cmake
@@ -33,6 +33,9 @@ if( "${CMAKE_CUDA_COMPILER_ID}" MATCHES "NVIDIA" )
    covfie_add_flag( CMAKE_CUDA_FLAGS "--expt-relaxed-constexpr" )
 endif()
 
+covfie_add_flag( CMAKE_CUDA_FLAGS "-Wfloat-conversion" )
+covfie_add_flag( CMAKE_CUDA_FLAGS "-Wconversion" )
+
 # Fail on warnings, if asked for that behaviour.
 if( COVFIE_FAIL_ON_WARNINGS )
    if( ( "${CUDAToolkit_VERSION}" VERSION_GREATER_EQUAL "10.2" ) AND