Add ordering application #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an application that implements ordering for datagram oriented protocols.
Since timeouts are necessary to implement the ordering process reliably, the timeout API has been completed, so that it can be used to actually set, cancel, and trigger timeouts.
Additionally, some changes to the application layering API had to be done. With the current design it was not possible to add more than a single application protocol to the stack, due to a design flaw with the
write_packetfunction. This fix required reverting theBASPapplication to use templates again. Hence, the big change inapplication.cppandapplication.hppThis PR is based on #76 and should be merged/reviewed after that has been merged.