Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issues in juniper-advanced example #673

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

ethagnawl
Copy link
Contributor

This PR addresses two issues I ran into while running the "juniper-advanced" example:

  • Encoding error in mysql-schema.sql
    • I'm admittedly not sure how broadly useful this is, as I don't regularly use mysql but I had to replace instances of utf8mb with utf8 and utf8mb4_0900_ai_ci with utf8_general_ci in order to import the DB schema. I'm running: mysql Ver 15.1 Distrib 10.5.21-MariaDB, for debian-linux-gnu (x86_64) using EditLine wrapper
  • Fix schema descriptions in root.rs which were referring to the wrong table (user => product)

@robjtede
Copy link
Member

I had to replace instances of utf8mb with utf8

hmm this is definitely not right, utf8 is legacy and not really correct

@robjtede robjtede enabled auto-merge (squash) December 11, 2023 06:51
@robjtede
Copy link
Member

robjtede commented Dec 11, 2023

I'm guessing the newer utf8mb4_0900_ai_ci collation is not supported in your version of mysql. I've changed the charset back to utf8mb4 and updated the collate to utf8mb4_unicode_ci to support a larger range of mysql versions. Let me know if that combo works for you.

@robjtede robjtede merged commit c34afd3 into actix:master Dec 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants