-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Replace sha1 dependency with sha-1 #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update CHANGES.md?
Done. |
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
==========================================
+ Coverage 77.98% 80.47% +2.49%
==========================================
Files 159 159
Lines 18538 18541 +3
==========================================
+ Hits 14456 14921 +465
+ Misses 4082 3620 -462
Continue to review full report at Codecov.
|
Sorry again, could you rebase to make CI green? |
Ah, could you add a unit test to confirm that the output isn't changed? like: #[test]
fn test_hash_key() {
let foo = hash_key("hello actix-web".as_bytes());
assert_eq!(&foo, "cR1dlyUUJKp0s/Bel25u5TgvC3E=");
} |
This other crate is being maintained, and it offers better performances when using the `asm` feature (especially [on AArch64](RustCrypto/hashes#97)).
Done. |
Thanks! |
This other crate is being maintained, and it offers better performances when using the
asm
feature (especially on AArch64).