Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Function to run all i18n tests locally #995

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

zeus2611
Copy link
Contributor

@zeus2611 zeus2611 commented Oct 22, 2024

Added centralized script to run all i18n tests and configured pre-commit hook to ensure these tests are run and checks are passed before opening a PR.

Contributor checklist


Description

Related issue

Added centralized script to run all i18n tests and configured pre-commit hook to ensure these tests are run and checks are passed before opening a PR.
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit cb729a0
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6717c999660df4000814d697
😎 Deploy Preview https://deploy-preview-995--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 23, 2024
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, @zeus2611 :) Thanks a lot for a great first contribution 😊

@andrewtavis andrewtavis merged commit 7517dce into activist-org:main Oct 23, 2024
5 checks passed
@zeus2611 zeus2611 deleted the 990-i18n-local-test branch October 23, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants