-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue Resolved : Add missing image alt texts for localization (#405) #410
Conversation
…he file which included alt for images and linked the alt text to the en-US.json file
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you! Maintainer checklist
|
❌ Deploy Preview for activist-org failed.
|
Thank you, @hariFED! Looking forward to checking this out :) I'm a bit ill at the moment, so it will be a few days, but I appreciate you getting to this so quickly! 🙏 |
Thank you so much for your quick response. I really appreciate it! Take your time and don't worry about the delay, your health comes first. I hope you get well soon. Looking forward for the feedback about the code changes when you're feeling better. Thanks again for assigning me in this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks really great, @hariFED 😊
I seem to have messed something up when fixing the merge conflicts, but I'll figure it out on my end! I switched over activist.org/about to be an index page, so that lead to some conflicts with this, but should be easy enough.
I'll merge, and the expectation will be that it won't deploy, but I'll follow it up shortly with the needed fixes to get this done 🚀 Thanks for the work here! Sorry that the review took a bit of time. Have been a bit sick and needed to rest :)
I am happy to rework on this issue as it's just the path need to be changed and some changes i json file. Any way Happy to contribute to your project 😊. |
Description
Add image alt texts to the en-US.json file to enable localization.
Related Issue
Resolves #405
Motivation and Context
There are alt texts in the codebase that are currently hard-coded and not localized. This pull request aims to fix this issue by adding the missing alt texts to the en-US.json file, allowing for proper localization.
Changes Made
How to Test
Checklist
Additional Notes
Please review this pull request and provide any feedback or suggestions. I'm happy to address any concerns or make further improvements if needed.