Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Resolved : Add missing image alt texts for localization (#405) #410

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

hariFED
Copy link
Contributor

@hariFED hariFED commented Sep 27, 2023

Description

Add image alt texts to the en-US.json file to enable localization.

Related Issue

Resolves #405

Motivation and Context

There are alt texts in the codebase that are currently hard-coded and not localized. This pull request aims to fix this issue by adding the missing alt texts to the en-US.json file, allowing for proper localization.

Changes Made

  • Added new keys-value pairs to the en-US.json file for each missing alt text.
  • Modified the codebase to utilize the new keys using the $t() syntax.

How to Test

  • Check that the en-US.json file now contains the added keys and corresponding alt texts.
  • Verify that the codebase is updated to use the $t() syntax for alt texts.
  • Test the application's functionality and ensure that the images display the correct alt texts based on the selected language.

Checklist

  • Self-reviewed my own code
  • Ensured that the code follows the project's coding standards and style guidelines
  • Verified that all tests pass successfully

Additional Notes

Please review this pull request and provide any feedback or suggestions. I'm happy to address any concerns or make further improvements if needed.

…he file which included alt for images and linked the alt text to the en-US.json file
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for activist-org failed.

Name Link
🔨 Latest commit bf96aaa
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/65212561d0a64d00086fd0a8

@andrewtavis andrewtavis self-requested a review September 27, 2023 17:36
@andrewtavis
Copy link
Member

Thank you, @hariFED! Looking forward to checking this out :) I'm a bit ill at the moment, so it will be a few days, but I appreciate you getting to this so quickly! 🙏

@hariFED
Copy link
Contributor Author

hariFED commented Sep 27, 2023

Thank you so much for your quick response. I really appreciate it! Take your time and don't worry about the delay, your health comes first. I hope you get well soon. Looking forward for the feedback about the code changes when you're feeling better. Thanks again for assigning me in this issue.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks really great, @hariFED 😊

I seem to have messed something up when fixing the merge conflicts, but I'll figure it out on my end! I switched over activist.org/about to be an index page, so that lead to some conflicts with this, but should be easy enough.

I'll merge, and the expectation will be that it won't deploy, but I'll follow it up shortly with the needed fixes to get this done 🚀 Thanks for the work here! Sorry that the review took a bit of time. Have been a bit sick and needed to rest :)

@andrewtavis andrewtavis merged commit 0fe4fa2 into activist-org:main Oct 7, 2023
3 of 6 checks passed
@hariFED
Copy link
Contributor Author

hariFED commented Oct 10, 2023

I am happy to rework on this issue as it's just the path need to be changed and some changes i json file. Any way Happy to contribute to your project 😊.

@hariFED hariFED deleted the add-img-alt-text branch October 18, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add all image alt texts to the en-US.json file
2 participants