feat(component): Created calendar input using vcalendar library #218

rohram04 · 2023-07-10T20:12:54Z

Contributor checklist

This pull request is on a separate branch and not the main branch

Description

Created a calendar input form using the vcalendar library as discussed in #169. The API Request needs to be adjusted once a corresponding backend endpoint is created and a calendar to display the events is being made. In it's current form this is not complete or ready to be merged. I am looking for input as I develop the component. The changes have been tested using the following CodeSandbox Environment

Related issue

Calendar component for event creation / home page #169

netlify · 2023-07-10T20:12:59Z

❌ Deploy Preview for activist-org failed.

Name	Link
🔨 Latest commit	`63d6d2c`
🔍 Latest deploy log	https://app.netlify.com/sites/activist-org/deploys/6525bd2f4155510008401997

github-actions · 2023-07-10T20:13:11Z

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you!

Maintainer checklist

The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

andrewtavis · 2023-07-10T20:32:19Z

Hey @rohram04 👋

Thanks for the PR here :)

Not sure if you can see the deploy log, but the error here is the following:

[vite]: Rollup failed to resolve import v-calendar from /opt/build/repo/frontend/components/Media/Calendar.vue.
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`

rohram04 · 2023-07-10T20:35:20Z

Hey @rohram04 👋

Thanks for the PR here :)

Not sure if you can see the deploy log, but the error here is the following:

[vite]: Rollup failed to resolve import v-calendar from /opt/build/repo/frontend/components/Media/Calendar.vue.
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`

That's odd I made sure to install the package. Let me look into it. In the meantime if you want to check out the component you can visit CodeSandbox and run npm run dev

EDIT: Ok there still seems to be an issue. I had previously installed the npm package in the root directory instead of ./frontend. Despite installing the dependency to the frontend directory there still seems to be an issue. I have been a little lazy by not setting up a full docker environment but I will do so to fix this build issue.

andrewtavis · 2023-07-20T18:47:55Z

Hey @rohram04! Finally have some time to get to some of these PRs :) How are you doing on this? Do you need some help getting Docker setup for yourself?

Overall comments: as I said in the dev sync it's really looking good. I would maybe style it such that the time selection is on the same row rather than one on top of the other (we can do one on top of the other for mobile as we'll have less space).

rohram04 · 2023-07-25T12:40:11Z

Hey @rohram04! Finally have some time to get to some of these PRs :) How are you doing on this? Do you need some help getting Docker setup for yourself?

Overall comments: as I said in the dev sync it's really looking good. I would maybe style it such that the time selection is on the same row rather than one on top of the other (we can do one on top of the other for mobile as we'll have less space).

Hello, I had some issues using docker. Docker itself is setup but when I run docker-compose up the backend runs fine but the frontend produces the following error log;

2023-07-25 08:29:35 Nuxi 3.6.2
2023-07-25 08:29:35 Nuxt 3.6.2 with Nitro 2.5.2
2023-07-25 08:29:36 
2023-07-25 08:29:36   > Listening:    http://localhost:3000/ 
2023-07-25 08:29:36 
2023-07-25 08:29:37 ℹ Using Tailwind CSS from ~/assets/css/tailwind.css
2023-07-25 08:29:38 ℹ Tailwind Viewer: http://localhost:3000/_tailwind/
2023-07-25 08:29:45 [nitro] [uncaughtException] Error: listen EADDRINUSE: address already in use /tmp/nitro/worker-39-1.sock
2023-07-25 08:27:01 
2023-07-25 08:27:01  ERROR  Failed to load url /node_modules/dist/vue-i18n.mjs (resolved id: /app/node_modules/dist/vue-i18n.mjs). Does the file exist?
2023-07-25 08:27:01 
2023-07-25 08:27:05 
2023-07-25 08:27:05  ERROR  Failed to load url /node_modules/dist/vue-i18n.mjs (resolved id: /app/node_modules/dist/vue-i18n.mjs) in /app/node_modules/@nuxtjs/i18n/dist/runtime/plugin.mjs. Does the file exist?
2023-07-25 08:27:05 
2023-07-25 08:27:06 
2023-07-25 08:27:06  ERROR  Failed to resolve import "/app/node_modules/dist/vue-i18n.mjs" from "components/Menu/MenuMeatball.vue". Does the file exist?
2023-07-25 08:27:06 
2023-07-25 08:27:06 
2023-07-25 08:27:06  ERROR  Failed to resolve import "/app/node_modules/dist/vue-i18n.mjs" from "components/Selector/SelectorLanguage.vue". Does the file exist?
2023-07-25 08:27:06 
2023-07-25 08:27:06 
2023-07-25 08:27:06  ERROR  Failed to resolve import "/app/node_modules/dist/vue-i18n.mjs" from "components/Sidebar/SidebarFooter.vue". Does the file exist?
2023-07-25 08:27:06 
2023-07-25 08:27:07 ✘ [ERROR] Could not read from file: /app/node_modules/dist/vue-i18n.mjs
2023-07-25 08:27:07 
2023-07-25 08:27:07     node_modules/@intlify/vue-i18n-bridge/lib/index.mjs:10:14:
2023-07-25 08:27:07       10 │ export * from 'vue-i18n'
2023-07-25 08:27:07          ╵               ~~~~~~~~~~
2023-07-25 08:27:07 
2023-07-25 08:27:07 
2023-07-25 08:27:07  ERROR  error while updating dependencies:
2023-07-25 08:27:07 Error: Build failed with 1 error:
2023-07-25 08:27:07 node_modules/@intlify/vue-i18n-bridge/lib/index.mjs:10:14: ERROR: Could not read from file: /app/node_modules/dist/vue-i18n.mjs
2023-07-25 08:27:07     at failureErrorWithLog (/app/node_modules/vite/node_modules/esbuild/lib/main.js:1636:15)
2023-07-25 08:27:07     at /app/node_modules/vite/node_modules/esbuild/lib/main.js:1048:25
2023-07-25 08:27:07     at /app/node_modules/vite/node_modules/esbuild/lib/main.js:1512:9
2023-07-25 08:27:07     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-07-25 08:27:07 
2023-07-25 08:29:43 
2023-07-25 08:29:43  ERROR  Failed to load url /node_modules/dist/vue-i18n.mjs (resolved id: /app/node_modules/dist/vue-i18n.mjs). Does the file exist?
2023-07-25 08:29:43 
2023-07-25 08:29:47 
2023-07-25 08:29:47  ERROR  Failed to load url /node_modules/dist/vue-i18n.mjs (resolved id: /app/node_modules/dist/vue-i18n.mjs) in /app/node_modules/@nuxtjs/i18n/dist/runtime/plugin.mjs. Does the file exist?
2023-07-25 08:29:47 
2023-07-25 08:29:48 
2023-07-25 08:29:48  ERROR  Failed to resolve import "/app/node_modules/dist/vue-i18n.mjs" from "components/Selector/SelectorLanguage.vue". Does the file exist?
2023-07-25 08:29:48 
2023-07-25 08:29:48 
2023-07-25 08:29:48  ERROR  Failed to resolve import "/app/node_modules/dist/vue-i18n.mjs" from "components/Menu/MenuMeatball.vue". Does the file exist?
2023-07-25 08:29:48 
2023-07-25 08:29:48 
2023-07-25 08:29:48  ERROR  Failed to resolve import "/app/node_modules/dist/vue-i18n.mjs" from "components/Sidebar/SidebarFooter.vue". Does the file exist?
2023-07-25 08:29:48 
2023-07-25 08:29:49 ✘ [ERROR] Could not read from file: /app/node_modules/dist/vue-i18n.mjs
2023-07-25 08:29:49 
2023-07-25 08:29:49     node_modules/@intlify/vue-i18n-bridge/lib/index.mjs:10:14:
2023-07-25 08:29:49       10 │ export * from 'vue-i18n'
2023-07-25 08:29:49          ╵               ~~~~~~~~~~
2023-07-25 08:29:49 
2023-07-25 08:29:49 
2023-07-25 08:29:49  ERROR  error while updating dependencies:
2023-07-25 08:29:49 Error: Build failed with 1 error:
2023-07-25 08:29:49 node_modules/@intlify/vue-i18n-bridge/lib/index.mjs:10:14: ERROR: Could not read from file: /app/node_modules/dist/vue-i18n.mjs
2023-07-25 08:29:49     at failureErrorWithLog (/app/node_modules/vite/node_modules/esbuild/lib/main.js:1636:15)
2023-07-25 08:29:49     at /app/node_modules/vite/node_modules/esbuild/lib/main.js:1048:25
2023-07-25 08:29:49     at /app/node_modules/vite/node_modules/esbuild/lib/main.js:1512:9
2023-07-25 08:29:49     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-07-25 08:29:49 
2023-07-25 08:29:45     at Server.setupListenHandle [as _listen2] (node:net:1757:21)
2023-07-25 08:29:45     at listenInCluster (node:net:1822:12)
2023-07-25 08:29:45     at Server.listen (node:net:1921:5)
2023-07-25 08:29:45     at file:///app/.nuxt/dev/index.mjs:3848:8
2023-07-25 08:29:45     at ModuleJob.run (node:internal/modules/esm/module_job:193:25) {
2023-07-25 08:29:45   code: 'EADDRINUSE',
2023-07-25 08:29:45   errno: -98,
2023-07-25 08:29:45   syscall: 'listen',
2023-07-25 08:29:45   address: '/tmp/nitro/worker-39-1.sock',
2023-07-25 08:29:45   port: -1
2023-07-25 08:29:45 }
2023-07-25 08:29:49 ℹ Vite client warmed up in 9005ms
2023-07-25 08:29:50 [nitro] ✔ Nitro built in 1756 ms

It says it's missing some modules. I'm going to look into it myself but just wanted to see if you have seen this before and have any ideas for dealing with it?

andrewtavis · 2023-07-25T17:21:17Z

Updated your comment so there’s formatting for the code, @rohram04 :) Will take a look into it!

andrewtavis · 2023-07-25T20:51:44Z

@rohram04, glad that Docker is generally working except for this error :) Some suggestions I have:

Try docker-compose up --build instead
Remove the .nuxt folder from /frontend and run docker-compose up --build
If you're using Docker Desktop, delete the container and run docker-compose up --build

Let me know if any of these help :) I'm hopeful that just the first one will get us to a working build 😊

andrewtavis · 2023-07-27T20:51:37Z

@rohram04, quick note that in #240 the components directory you're committing to was renamed media from Media to better fit Nuxt standards :) Let's keep this in mind.

Let me know if there's anything else I can do to help!

andrewtavis

Hey there @rohram04 👋 Appreciate the work here. I'll bring it in at this point and will work to finish it in the coming weeks :)

feat(component): Created calendar input using vcalendar library

970a128

andrewtavis self-requested a review July 10, 2023 20:32

fixed dependency issue

c8a88de

andrewtavis mentioned this pull request Jul 23, 2023

Lower case components sub directory names #240

Closed

2 tasks

andrewtavis added 2 commits October 10, 2023 23:05

Merge branch 'main' into calendar

3d9ed5f

Remove all changes from package.json

63d6d2c

andrewtavis approved these changes Oct 10, 2023

View reviewed changes

andrewtavis merged commit 0e8151e into activist-org:main Oct 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(component): Created calendar input using vcalendar library #218

feat(component): Created calendar input using vcalendar library #218

rohram04 commented Jul 10, 2023

netlify bot commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023 •

edited by andrewtavis

Loading

andrewtavis commented Jul 10, 2023

rohram04 commented Jul 10, 2023 •

edited

Loading

andrewtavis commented Jul 20, 2023

rohram04 commented Jul 25, 2023 •

edited by andrewtavis

Loading

andrewtavis commented Jul 25, 2023

andrewtavis commented Jul 25, 2023

andrewtavis commented Jul 27, 2023

andrewtavis left a comment

feat(component): Created calendar input using vcalendar library #218

feat(component): Created calendar input using vcalendar library #218

Conversation

rohram04 commented Jul 10, 2023

Contributor checklist

Description

Related issue

netlify bot commented Jul 10, 2023 • edited Loading

❌ Deploy Preview for activist-org failed.

github-actions bot commented Jul 10, 2023 • edited by andrewtavis Loading

Thank you for the pull request!

Maintainer checklist

andrewtavis commented Jul 10, 2023

rohram04 commented Jul 10, 2023 • edited Loading

andrewtavis commented Jul 20, 2023

rohram04 commented Jul 25, 2023 • edited by andrewtavis Loading

andrewtavis commented Jul 25, 2023

andrewtavis commented Jul 25, 2023

andrewtavis commented Jul 27, 2023

andrewtavis left a comment

Choose a reason for hiding this comment

netlify bot commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023 •

edited by andrewtavis

Loading

rohram04 commented Jul 10, 2023 •

edited

Loading

rohram04 commented Jul 25, 2023 •

edited by andrewtavis

Loading