Added SPDX license identifiers to .vue, .ts, and .py files #1081
Conversation
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local activist repo (can be set withgit config --global user.email "GITHUB_EMAIL")
|
Thanks for the commit, @Mahendradoak! Would you be able to add these to all files? And for Python files, if there is a file level documentation string could you put the license notice at the top? So like this: """
# SPDX-License-Identifier: AGPL-3.0-or-later
<REST_OF_DOC_STRING>
"""Let me know if you have any questions! |
|
Or never mind, I think it's fine to do the Python ones as you have, but let's always have them above :) So like this: # SPDX-License-Identifier: AGPL-3.0-or-later
"""
<DOC_STRING>
""" |
|
do i change the position and commit again or should I let it stay the way it is? |
|
It'd be great if you could change the position for the ones that are beneath the doc strings and add this notice to all files :) |
|
Just checking: Are you planning on re-opening, @Mahendradoak? |
|
yes i will be re-opening
…On Sun, Jan 12, 2025 at 8:54 PM Andrew Tavis McAllister < ***@***.***> wrote:
Just checking: Are you planning on re-opening, @Mahendradoak
<https://github.com/Mahendradoak>?
—
Reply to this email directly, view it on GitHub
<#1081 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDFSWR3CRH6GWI3GA7NP7D32KLI7FAVCNFSM6AAAAABVBKTTL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVHEYTEOBQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor checklist
Description
This pull request adds SPDX license identifiers to all
.vue,.ts, and.pyfiles in the project as required by the issue description. The identifiers added are:.vuefiles:<!-- SPDX-License-Identifier: AGPL-3.0-or-later -->.tsfiles:// SPDX-License-Identifier: AGPL-3.0-or-later.pyfiles:# SPDX-License-Identifier: AGPL-3.0-or-laterThese changes ensure that each file complies with the licensing requirements.
I verified the changes by reviewing each modified file to ensure the correct identifier was added and ran the necessary tests as described in the project's contributing guide to confirm that the project continues to function as expected.