Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1078 Split communties into groups and organizations #1079

Merged
merged 11 commits into from
Jan 12, 2025

Conversation

andrewtavis
Copy link
Member

Contributor checklist


Description

This PR splits all possible models, views, serializers and factories within communities into sub groups and organizations directories so that the code is more modular and easier to maintain.

Feedback and suggestions for improvements welcome!

Related issue

@andrewtavis andrewtavis requested a review from to-sta January 12, 2025 01:21
Copy link

netlify bot commented Jan 12, 2025

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit c42ff58
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6784268d8b7bdd0008eb6701
😎 Deploy Preview https://deploy-preview-1079--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewtavis andrewtavis linked an issue Jan 12, 2025 that may be closed by this pull request
2 tasks
Copy link
Contributor

github-actions bot commented Jan 12, 2025

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis mentioned this pull request Jan 12, 2025
@andrewtavis
Copy link
Member Author

The above commit also adds in some baseline communities.organizations tests :)

@andrewtavis
Copy link
Member Author

After dealing with Docker kicking the bucket for all macOS users I'm back up and running and was able to do the final tests in the UI just now. Lots of progress here, @to-sta! Thanks for the session earlier today and looking forward to these final big backend architecture steps getting checked off ✅😊

@andrewtavis andrewtavis merged commit b6ff021 into main Jan 12, 2025
7 checks passed
@andrewtavis andrewtavis deleted the 1078-split-communities branch January 12, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split communities files into groups and organizations
2 participants