Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added regex logic for groups and events in PageBreadcrumbs.vue #1062

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

shgxshg
Copy link
Contributor

@shgxshg shgxshg commented Dec 11, 2024

Contributor checklist

  • This pull request is on a separate branch and not the main branch
  • [] I have given maintainers the ability to edit this pull request
  • [] I have run the tests for the backend and frontend depending on what's needed for my changes as described in the testing section of the contributing guide

Description

This pull request enhances the route-checking logic in PageBreadcrumbs.vue by introducing robust mechanisms for handling group and event routes.

groupRegex validates routes with the format /organizations/{UUID}/groups/{UUID} and optionally /about. This ensures accurate identification of "group" page types and triggers fetching group details from the groupStore using the fetchById method. This addition enables seamless navigation and dynamic content updates for group-related pages.
eventRegex validates routes with the format /events/{UUID} and optionally /about. This allows for precise identification of "event" page types and ensures event details are fetched from the eventStore using the fetchById method.

Related issue

resolves #920

Copy link
Contributor

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 64bf427
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/675a118dfb6d5f0008cf95e5
😎 Deploy Preview https://deploy-preview-1062--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewtavis andrewtavis self-requested a review December 11, 2024 22:27
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the pull request and the communication here, @shgxshg! Glad to have this in and have the changes you all have been making reflected for groups and events as well 😊

@andrewtavis andrewtavis merged commit 39aab66 into activist-org:main Dec 11, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement page checks that rely on UUIDs
2 participants