Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin testing dependencies #1033

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

cquinn540
Copy link
Collaborator

Contributor checklist


Description

Pin testing dependencies. If they aren't pinned updates to yarn.lock will happen in random PRs which makes it harder to track dependency changes.

Related issue

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit ed86d7e
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/674dcd3494f8460008547ff4
😎 Deploy Preview https://deploy-preview-1033--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cquinn540 cquinn540 mentioned this pull request Dec 2, 2024
1 task
@andrewtavis andrewtavis self-requested a review December 2, 2024 21:34
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for diagnosing the issue here and getting a fix so quickly, @cquinn540! 🚀

@andrewtavis andrewtavis merged commit bfbc0f5 into activist-org:main Dec 2, 2024
7 checks passed
@cquinn540 cquinn540 deleted the pin-testing-deps branch December 3, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants