Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Updates sorting example #1442

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

kinduff
Copy link
Contributor

@kinduff kinduff commented Oct 5, 2023

Closes #1419

Updates the sorting code examples to be vanilla and make it clear how to use sorting.

Easy code review in this gist.

@kinduff kinduff changed the title Updates sorting example Docs: Updates sorting example Oct 5, 2023
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a nice improvement! Thanks!

@deivid-rodriguez deivid-rodriguez merged commit 2920583 into activerecord-hackery:main Oct 20, 2023
23 checks passed
@kinduff kinduff deleted the patch-1 branch October 21, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing info in sorting documentation
2 participants