fix eql? method

activerecord-hackery · Sep 13, 2024 · 8475772 · 8475772
1 parent b338cd4
commit 8475772
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/ransack/nodes/condition.rb b/lib/ransack/nodes/condition.rb
@@ -204,12 +204,13 @@ def eql?(other)
         self.attributes == other.attributes &&
         self.predicate == other.predicate &&
         self.values == other.values &&
-        self.combinator == other.combinator
+        self.combinator == other.combinator &&
+        self.name == other.name
       end
       alias :== :eql?
 
       def hash
-        [attributes, predicate, values, combinator].hash
+        [attributes, predicate, values, combinator, name].hash
       end
 
       def predicate_name=(name)

diff --git a/spec/ransack/nodes/condition_spec.rb b/spec/ransack/nodes/condition_spec.rb
@@ -95,7 +95,10 @@ module Nodes
             Ransack.configure { |c| c.default_predicate = 'eq' }
           end
 
-          specify { expect(subject).to eq Condition.extract(Context.for(Person), 'full_name_eq', Person.first.name) }
+          specify do
+            expect(subject).not_to be_nil
+            expect(subject.predicate.name).to eq 'eq'
+          end
         end
       end
     end