Skip to content
This repository has been archived by the owner on Mar 30, 2022. It is now read-only.

incremented versions for gems to rails 6 ruby 2.7.0 and mongo 7 #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jesusalc
Copy link

M .travis.yml
M Gemfile
M Gemfile.lock
M ransack-mongoid.gemspec

Copy link

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good in general, but I commented some stuff. Thanks!

@@ -1,5 +1,5 @@
module Ransack
module Mongoid
VERSION = "0.1.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to bump the version, since nothing is really changing from a final user perspective. This PR is just making sure that this gem works against newest versions of dependencies.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the version bump, the gem does not update and it does not resolve the new decency versions.

spec.version = Ransack::Mongoid::VERSION
spec.authors = ["Ernie Miller", "Ryan Bigg", "Jon Atack","Sean Carroll"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you get to be added as the author of this gem just with a single contribution 😅. I'm grateful, and probably the authors of this gem too, for your contribution though.

In fact, I would personally revert all the changes in this file, since you only changing the quoting style, and adding your name and email address.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing so intensely. Is there anything that is missing or that requires attention for the gem to be ready for 6 ruby 2.7.0 and mongo 7 ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea, since it doesn't even seem this repo has TravisCI enabled. We can probably ask the current maintainers to add that?

Have you tried the gem in your application?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently using this version, hence the PR request.

else
gem 'mongoid', '~> 5.0.0', require: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gem should probably declare an official range of supported mongoid versions, and explicitly test those in CI. That sounds like something for a separate PR, though.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that but it breaks the older version.

@grzegorz-jakubiak
Copy link

could some of the maintainers take care of it? we want to add this functionality to activeadmin-mongoid.

@Ruxton
Copy link

Ruxton commented Jun 30, 2020

@grzegorz-jakubiak there are no maintainers, have you considered becoming one?

@jesusalc
Copy link
Author

@grzegorz-jakubiak there are no maintainers, have you considered becoming one?
@Ruxton I could become one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants