Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvei: Add GSF for verify method #5278

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

javierpedrozaing
Copy link
Collaborator

Description

SER-1462

This commit add authenticationOnlyType as GSF for a verify request

Unit test

Finished in 0.009788 seconds.

18 tests, 99 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

1838.99 tests/s, 10114.43 assertions/s

Remote test

Finished in 121.496082 seconds.

28 tests, 87 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

0.23 tests/s, 0.72 assertions/s

Rubocop

801 files inspected, no offenses detected

@javierpedrozaing javierpedrozaing force-pushed the SER-1461_nuvei_verify_authentication_only_type branch from 048053c to be454c5 Compare September 27, 2024 13:28
@javierpedrozaing javierpedrozaing force-pushed the SER-1461_nuvei_verify_authentication_only_type branch from be454c5 to 490c3a7 Compare October 7, 2024 15:11
@javierpedrozaing javierpedrozaing marked this pull request as ready for review October 7, 2024 15:17
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@naashton naashton force-pushed the SER-1461_nuvei_verify_authentication_only_type branch from 490c3a7 to 0021ade Compare October 18, 2024 16:37
Description
-------------------------
[SER-1462](https://spreedly.atlassian.net/browse/SER-1462)

This commit add authenticationOnlyType as GSF for a verify request

Unit test
-------------------------
Finished in 0.009788 seconds.

18 tests, 99 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

1838.99 tests/s, 10114.43 assertions/s

Remote test
-------------------------
Finished in 121.496082 seconds.

28 tests, 87 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

0.23 tests/s, 0.72 assertions/s

Rubocop
-------------------------
801 files inspected, no offenses detected
@naashton naashton force-pushed the SER-1461_nuvei_verify_authentication_only_type branch from 0021ade to 94c88ca Compare October 18, 2024 16:41
@naashton naashton merged commit 4d0d1da into master Oct 18, 2024
5 checks passed
@naashton naashton deleted the SER-1461_nuvei_verify_authentication_only_type branch October 18, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants