NMI: Add shipping_firstname, shipping_lastname, shipping_email, and s… #4825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelkirk
approved these changes
Jul 11, 2023
| @@ -232,6 +233,9 @@ def add_customer_data(post, options) | |||
| end | |||
|
|
|||
| if (shipping_address = options[:shipping_address]) | |||
| first_name, last_name = split_names(shipping_address[:name]) | |||
…urcharge fields CER-666 CER-673 LOCAL 5547 tests, 77613 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 760 files inspected, no offenses detected UNIT 56 tests, 454 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed REMOTE 51 tests, 184 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 94.1176% passed *Test failures are related to Apple Pay and eCheck, and are also failing on master
jcreiff
force-pushed
the
nmi_shipping_fields_and_surcharge
branch
from
e3db259
to
5c9bd17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…urcharge fields
CER-666
CER-673
LOCAL
5547 tests, 77613 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
760 files inspected, no offenses detected
UNIT
56 tests, 454 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
REMOTE
51 tests, 184 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 94.1176% passed
*Test failures are related to Apple Pay and eCheck, and are also failing on master