Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use cached relpath in parallel code #2738

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Conversation

FayazRahman
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • The custom cached relpath function is not thread-safe so don't use it in parallel code paths.

Things to be aware of

Things to worry about

Additional Context

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d952ab6) 84.51% compared to head (20b3345) 83.92%.
Report is 3 commits behind head on main.

Files Patch % Lines
deeplake/core/vectorstore/deeplake_vectorstore.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2738      +/-   ##
==========================================
- Coverage   84.51%   83.92%   -0.59%     
==========================================
  Files         233      233              
  Lines       26452    26452              
==========================================
- Hits        22356    22200     -156     
- Misses       4096     4252     +156     
Flag Coverage Δ
unittests 83.92% <83.33%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@FayazRahman FayazRahman merged commit fc047ab into main Jan 13, 2024
8 of 12 checks passed
@FayazRahman FayazRahman deleted the fy_thread_safety branch January 13, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants