Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from Waitlist concept in DeepMemory access #2730

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

dgaloop
Copy link
Contributor

@dgaloop dgaloop commented Dec 28, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR will remove the references to Waitlist when checking the access to DeepMemory.
Currently, DeepMemory access will be automatically granted to anyone on a Paid Org plan. (Similar to now previously query access was granted)

Please note that some test cases might need to be adjusted accordingly.

Things to be aware of

Things to worry about

Additional Context

@dgaloop dgaloop requested a review from AdkSarsen December 28, 2023 13:00
@CLAassistant
Copy link

CLAassistant commented Dec 28, 2023

CLA assistant check
All committers have signed the CLA.

@dgaloop dgaloop marked this pull request as ready for review January 3, 2024 11:48
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23a37d1) 84.41% compared to head (18154dc) 83.94%.
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2730      +/-   ##
==========================================
- Coverage   84.41%   83.94%   -0.48%     
==========================================
  Files         233      233              
  Lines       26245    26447     +202     
==========================================
+ Hits        22154    22200      +46     
- Misses       4091     4247     +156     
Flag Coverage Δ
unittests 83.94% <100.00%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jan 8, 2024

@nvoxland-al nvoxland-al merged commit 7cb4ab0 into main Jan 9, 2024
11 of 12 checks passed
@nvoxland-al nvoxland-al deleted the remove-waitlist-term branch January 9, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants