Skip to content

Store result ids on ImportResult (postgres only) #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

saulm
Copy link

@saulm saulm commented May 13, 2021

I was looking for a solution to #179

Luckily I'm using postgres, and activerecord-import stores the ids for postgres: https://github.com/zdennis/activerecord-import#return-info

I understand this is not the ideal solution for everyone, but it's consistent with the behavior of the underlying base library.

Let me know if this is something you would like to add or if you need any other changes.

@coveralls
Copy link

coveralls commented May 13, 2021

Coverage Status

Coverage decreased (-0.006%) to 97.98% when pulling 54fb15b on polyglot-solutions:master into 1c7601f on activeadmin-plugins:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants