Parent resource is made accesible through the template object when th… #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e active admin page has the 'belongs_to' statement.
houndci-bot
reviewed
Apr 12, 2017
| @@ -76,7 +76,9 @@ def active_admin_import(options = {}, &block) | |||
| _params = params.respond_to?(:to_unsafe_h) ? params.to_unsafe_h : params | |||
| params = ActiveSupport::HashWithIndifferentAccess.new _params | |||
| @active_admin_import_model = options[:template_object] | |||
| @active_admin_import_model.assign_attributes(params[params_key].try(:deep_symbolize_keys) || {}) | |||
| @active_admin_import_model.assign_attributes(params[params_key].try(:deep_symbolize_keys) || {}) | |||
| @active_admin_import_model.assign_attributes(parent: parent) unless defined?(parent).nil? | |||
| @@ -76,7 +76,9 @@ def active_admin_import(options = {}, &block) | |||
| _params = params.respond_to?(:to_unsafe_h) ? params.to_unsafe_h : params | |||
| params = ActiveSupport::HashWithIndifferentAccess.new _params | |||
| @active_admin_import_model = options[:template_object] | |||
| @active_admin_import_model.assign_attributes(params[params_key].try(:deep_symbolize_keys) || {}) | |||
| @active_admin_import_model.assign_attributes(params[params_key].try(:deep_symbolize_keys) || {}) | |||
There was a problem hiding this comment.
Line is too long. [112/80]
Trailing whitespace detected.
|
@ricardojudo , for new features to merge there is a requirement to add spec here https://github.com/activeadmin-plugins/active_admin_import/blob/master/spec/import_spec.rb |
Fivell
requested changes
Apr 18, 2017
| @@ -76,7 +76,9 @@ def active_admin_import(options = {}, &block) | |||
| _params = params.respond_to?(:to_unsafe_h) ? params.to_unsafe_h : params | |||
| params = ActiveSupport::HashWithIndifferentAccess.new _params | |||
| @active_admin_import_model = options[:template_object] | |||
| @active_admin_import_model.assign_attributes(params[params_key].try(:deep_symbolize_keys) || {}) | |||
| @active_admin_import_model.assign_attributes(params[params_key].try(:deep_symbolize_keys) || {}) | |||
| @active_admin_import_model.assign_attributes(parent: parent) unless defined?(parent).nil? | |||
There was a problem hiding this comment.
@ricardojudo , why not
if parent? instead of defined?(parent).nil?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e active admin page has the 'belongs_to' statement.
I needed to implement this change in order to get a reference of the parent resource within a proc passed to the before_batch_import option in order to insert additional information to each line.
I was not sure where and how to document this change.
What do you think about this proposal?