Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Adoptopenjdk package type look at the Temurin repo first for latest assets #522

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

johnoliver
Copy link

We are looking to move people off of the old deprecated Adoptopenjdk API to the Temurin API for Hotspot builds.

For the vast majority of binaries, the Temurin API will contain the one you want, the outlier cases are:

  • User is using an older (<16) non-lts release
  • User is requesting a very specific version from before Temurin

In both cases it means that they are using very old builds.

In order to move to the new API, this PR is proposing that requests to AdoptDistribution, are requested against TemurinDistribution first, if they cannot be satisfied by Temurin, then continue the existing unchanged AdoptOpenJDK logic. For the VAST majority of requests, they will be satisfied by Temurin, for the few remaining outliers described above, they will make a second request to the old AdoptOpenJDK API.

I am submitting this as a draft to ask if this approach is acceptable in principle.

@gdams
Copy link
Contributor

gdams commented Aug 9, 2023

I'm wondering whether we could add an annotation the pipeline to alert users to the fact that they should switch to temurin as their distro if the version they have requested is matched in temurin.

@gdams
Copy link
Contributor

gdams commented Aug 25, 2023

@ IvanZosimov can I get your thoughts on this PR please.

@IvanZosimov
Copy link
Contributor

Hi, @johnoliver and @gdams 👋 Actually, we have a piece of documentation about this problem: https://github.com/actions/setup-java#supported-distributions. Frankly speaking, we'd better wait for the official announcement of the full deprecation of the AdoptOpenJDK; after that, we could make an announcement for our customers. Given that many customers are aware of the deprecation but continue to use the outdated versions, the warning option also doesn't seem to be the best as it could create a lot of noise.

@IvanZosimov IvanZosimov self-assigned this Aug 28, 2023
@gdams
Copy link
Contributor

gdams commented Aug 28, 2023

Hi, @johnoliver and @gdams 👋 Actually, we have a piece of documentation about this problem: https://github.com/actions/setup-java#supported-distributions. Frankly speaking, we'd better wait for the official announcement of the full deprecation of the AdoptOpenJDK; after that, we could make an announcement for our customers. Given that many customers are aware of the deprecation but continue to use the outdated versions, the warning option also doesn't seem to be the best as it could create a lot of noise.

@IvanZosimov If you're looking for an official deprecation you can consider this blog post exactly that: https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/. The challenge here is that there are several Java versions that we released at AdoptOpenJDK that we don't release at Adoptium (e.g JDK 12-15 and 9-10). The idea of this change is that it will preserve functionality for those specific users but get the majority of users onto the newer API. As a side note, we should have a discussion with the dependabot team at some point to work out a plan for updating people's workflows.

@gdams
Copy link
Contributor

gdams commented Sep 8, 2023

@IvanZosimov what are your thoughts here? We'd love to find a solution to take some of the requests off our old API

@gdams
Copy link
Contributor

gdams commented Sep 8, 2023

@johnoliver looks like you need to run prettier and generate the dist files

@gdams
Copy link
Contributor

gdams commented Oct 13, 2023

ping @IvanZosimov it would be good to make some progress here

@IvanZosimov
Copy link
Contributor

Hi, @gdams and @johnoliver 👋 I apologize for taking so long to respond, we are overwhelmed at the moment! We discussed the idea of PR, and it seems acceptable to us. I think you can convert this PR to the real one, and we will take a look at it as we have time.

@johnoliver johnoliver marked this pull request as ready for review October 17, 2023 10:16
@johnoliver johnoliver requested a review from a team as a code owner October 17, 2023 10:16
@johnoliver
Copy link
Author

I have just noticed that the tests need fixing, will get on updating this

@johnoliver
Copy link
Author

Tests are fixed

@gdams
Copy link
Contributor

gdams commented Nov 13, 2023

@IvanZosimov this is good for review now

Calzadas

This comment was marked as spam.

@gdams
Copy link
Contributor

gdams commented Apr 10, 2024

@aparnajyothi-y any update here please?

@aparnajyothi-y aparnajyothi-y removed their assignment Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants