Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for artifact proxy repositories #434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kacamific
Copy link

Description:
This change supports teams that have configured their self-managed runners without internet access. They are proxying all the necessary public repositories via platforms like JFrog, Nexus etc. This can support especially teams that are using GHES.

I am proposing to add three inputs to action.yml
1- base url of the platform that is proxying the remote repositories
2- the download link that needs to be rewritten so the java binaries are download from this platforms
3- a context which might be necessary to build a proper download link. This might be necessary because the URL of the metadata.json file is different from the URL of the download link and the assumption is that teams have only one platform to proxy the remote repositores.

Related issue:

Check list:

  • [ x] Mark if documentation changes are required.
  • [ x] Mark if tests were added or updated to cover the changes.

@denizhoxha denizhoxha force-pushed the feature/support-proxy-repositoy branch from b23412e to cec33d9 Compare December 23, 2022 21:28
@denizhoxha denizhoxha requested a review from a team as a code owner December 23, 2022 21:28
@kuhlman-labs
Copy link

@marko-zivic-93 Any feedback on this PR?

@IvanZosimov
Copy link
Contributor

Hi, @kuhlman-labs 👋 We will investigate it and get back with our feedback.

@IvanZosimov IvanZosimov added feature request New feature or request to improve the current logic needs eyes labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic needs eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants