Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ppc64le support #436

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

shahidhs-ibm
Copy link

Description:
This PR will add support for ppc64le architecture. Official Go binaries are published for linux-ppc64, linux-ppc64le and aix-ppc64 variants. All these variants are being taken care of in the changes.

Related issue:
NA

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@shahidhs-ibm shahidhs-ibm requested a review from a team as a code owner October 19, 2023 11:34
@shahidhs-ibm
Copy link
Author

Can someone kindly review and let me know your comments.

@gucinmilan
Copy link

gucinmilan commented Nov 1, 2023 via email

@shahidhs-ibm
Copy link
Author

Any update?

@shahidhs-ibm
Copy link
Author

As per comment, tried with go versions >= 1.21 on self-hosted ppc64le runners but issue is still getting reproduced.

Getting following error logs in runner :

Run actions/setup-go@v4
Setup go version spec 1.21
Attempting to download 1.21...
matching 1.21...
Not found in manifest.  Falling back to download directly from Go
Install from dist
Acquiring go1.21.5 from https://storage.googleapis.com/golang/go1.21.5.linux-ppc64.tar.gz
Extracting Go...
/usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /opt/runner/_work/_temp/8a636f71-1358-4c04-b32f-6d996622f25d -f /opt/runner/_work/_temp/cbd160e3-ff36-4941-b1de-7f7381d28e15
Successfully extracted go to /opt/runner/_work/_temp/8a636f71-1358-4c04-b32f-6d996622f25d
Adding to the cache ...
Successfully cached go to /opt/runner/_work/_tool/go/1.21.5/ppc64
Added go to the path
Successfully set up Go version 1.21
/bin/sh: 1: go: Exec format error

So this PR is still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants