Support multiple packages #72
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| import {mockPackagesQueryResponse} from './graphql.mock' | ||
| import { | ||
| getRepoPackages as _getRepoPackages, | ||
| QueryInfo | ||
| } from '../../src/packages' | ||
| import {Observable} from 'rxjs' | ||
|
|
||
| describe.skip('get versions tests -- call graphql', () => { | ||
| it('getRepoPackages -- succeeds', done => { | ||
| const numPackages = 1 | ||
| getRepoPackages({numPackages}).subscribe(result => { | ||
| expect(result.packages.length).toBe(numPackages) | ||
| done() | ||
| }) | ||
| }) | ||
|
|
||
| it('getRepoPackages -- fails for invalid repo', done => { | ||
| getRepoPackages({repo: 'actions-testin'}).subscribe({ | ||
| error: err => { | ||
| expect(err).toBeTruthy() | ||
| done() | ||
| }, | ||
| complete: async () => done.fail('no error thrown') | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| describe('get versions tests -- mock graphql', () => { | ||
| it('getRepoPackages -- success', done => { | ||
| const numPackages = 5 | ||
| mockPackagesQueryResponse(numPackages) | ||
|
|
||
| getRepoPackages({numPackages}).subscribe(result => { | ||
| expect(result.packages.length).toBe(numPackages) | ||
| done() | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| interface Params { | ||
| owner?: string | ||
| repo?: string | ||
| numPackages?: number | ||
| startCursor?: string | ||
| token?: string | ||
| } | ||
|
|
||
| const defaultParams = { | ||
| owner: 'namratajha', | ||
| repo: 'test-repo', | ||
| packageName: 'test-repo', | ||
| numPackages: 1, | ||
| startCursor: '', | ||
| token: process.env.GITHUB_TOKEN as string | ||
| } | ||
|
|
||
| function getRepoPackages(params?: Params): Observable<QueryInfo> { | ||
| const p: Required<Params> = {...defaultParams, ...params} | ||
| return _getRepoPackages( | ||
| p.owner, | ||
| p.repo, | ||
| p.numPackages, | ||
| p.startCursor, | ||
| p.token | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import { | ||
| GraphQlQueryResponseData, | ||
| RequestParameters | ||
| } from '@octokit/graphql/dist-types/types' | ||
|
|
||
| import * as Graphql from '../../src/packages/graphql' | ||
| import {GetPackagesQueryResponse} from '../../src/packages' | ||
|
|
||
| export function getMockedPackagesQueryResponse( | ||
| numPackages: number | ||
| ): GetPackagesQueryResponse { | ||
| const packages = [] | ||
| for (let i = 1; i <= numPackages; ++i) { | ||
| packages.push({ | ||
| node: { | ||
| id: i.toString(), | ||
| name: `package${i}` | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| return { | ||
| repository: { | ||
| packages: { | ||
| totalCount: 200, | ||
| pageInfo: { | ||
| endCursor: 'AAA', | ||
| hasNextPage: false | ||
| }, | ||
| edges: packages | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| export function mockPackagesQueryResponse(numVersions: number): void { | ||
| const response = new Promise<GetPackagesQueryResponse>(resolve => { | ||
| resolve(getMockedPackagesQueryResponse(numVersions)) | ||
| }) as Promise<GraphQlQueryResponseData> | ||
| jest | ||
| .spyOn(Graphql, 'graphql') | ||
| .mockImplementation( | ||
| (token: string, query: string, parameters: RequestParameters) => response | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| import { getPackageNameFilter } from '../../src/packages' | ||
|
|
||
| describe('package name filter -- create filter', () => { | ||
|
|
||
| const packageNameList = [ | ||
| 'com.company.project.module1.package1', | ||
| 'com.company.project.module1.package2', | ||
| 'com.company.project.module2.package1', | ||
| 'com.company.project.module2.package2', | ||
| 'com.company.project.module3.package-name-lorem', | ||
| 'com.company.project.module3.package-name-ipsum', | ||
| 'com.company.project.module3.package-name-dolor', | ||
| ] | ||
|
|
||
| it('getPackageNameFilter -- wildcard end filter', done => { | ||
| const filter = getPackageNameFilter('com.company.project.module1.*') | ||
|
|
||
| const result = packageNameList.filter(filter.apply); | ||
|
|
||
| expect(filter.subfilters[0].type).toBe('wildcard') | ||
| expect(result).toEqual([ | ||
| 'com.company.project.module1.package1', | ||
| 'com.company.project.module1.package2', | ||
| ]) | ||
| done() | ||
| }) | ||
|
|
||
| it('getPackageNameFilter -- wildcard start filter', done => { | ||
| const filter = getPackageNameFilter('*.package1') | ||
|
|
||
| const result = packageNameList.filter(filter.apply); | ||
|
|
||
| expect(filter.subfilters[0].type).toBe('wildcard') | ||
| expect(result).toEqual([ | ||
| 'com.company.project.module1.package1', | ||
| 'com.company.project.module2.package1', | ||
| ]) | ||
| done() | ||
| }) | ||
|
|
||
| it('getPackageNameFilter -- wildcard both sides filter', done => { | ||
| const filter = getPackageNameFilter('*.project.module3.*') | ||
|
|
||
| const result = packageNameList.filter(filter.apply); | ||
|
|
||
| expect(filter.subfilters[0].type).toBe('wildcard') | ||
| expect(result).toEqual([ | ||
| 'com.company.project.module3.package-name-lorem', | ||
| 'com.company.project.module3.package-name-ipsum', | ||
| 'com.company.project.module3.package-name-dolor' | ||
| ]) | ||
| done() | ||
| }) | ||
|
|
||
|
|
||
| it('getPackageNameFilter -- wildcard all filter', done => { | ||
| const filter = getPackageNameFilter('*') | ||
|
|
||
| const result = packageNameList.filter(filter.apply); | ||
|
|
||
| expect(filter.subfilters[0].type).toBe('wildcard') | ||
| expect(result).toEqual(packageNameList.slice()) | ||
| done() | ||
| }) | ||
|
|
||
| it('getPackageNameFilter -- regex filter', done => { | ||
| const filter = getPackageNameFilter('/com\\.company\\.project\\.module.*\\.package1/') | ||
| const result = packageNameList.filter(filter.apply); | ||
|
|
||
| expect(filter.subfilters[0].type).toBe('regex') | ||
| expect(result).toEqual([ | ||
| 'com.company.project.module1.package1', | ||
| 'com.company.project.module2.package1', | ||
| ]) | ||
| done() | ||
| }) | ||
|
|
||
| it('getPackageNameFilter -- exact match filter', done => { | ||
| const filter = getPackageNameFilter('com.company.project.module1.package1') | ||
| const result = packageNameList.filter(filter.apply); | ||
|
|
||
| expect(filter.subfilters[0].type).toBe('string') | ||
| expect(result).toEqual(['com.company.project.module1.package1']) | ||
| done() | ||
| }) | ||
|
|
||
|
|
||
| it('getPackageNameFilter -- multiple filters', done => { | ||
| const filter = getPackageNameFilter('com.company.project.module1.package1, com.company.project.module2.*, /.*module3.*-ipsum/') | ||
| const result = packageNameList.filter(filter.apply); | ||
|
|
||
| expect(filter.subfilters.length).toBe(3) | ||
| expect(filter.subfilters[0].type).toBe('string') | ||
| expect(filter.subfilters[1].type).toBe('wildcard') | ||
| expect(filter.subfilters[2].type).toBe('regex') | ||
| expect(result).toEqual([ | ||
| 'com.company.project.module1.package1', | ||
| 'com.company.project.module2.package1', | ||
| 'com.company.project.module2.package2', | ||
| 'com.company.project.module3.package-name-ipsum' | ||
| ]) | ||
| done() | ||
| }) | ||
|
|
||
|
|
||
| it('getPackageNameFilter -- memoization, same input shoud return same output', done => { | ||
| const filterText = 'com.company.project.module1.package1, com.company.project.module2.*, /.*module3.*-dolor/, *.-lorem' | ||
| const filter1 = getPackageNameFilter(filterText) | ||
| const filter2 = getPackageNameFilter(filterText) | ||
| expect(filter1).toBe(filter2) | ||
| expect(filter1.subfilters.length).toBe(4) | ||
| done() | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo:
or package-namesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, thank you