Implement the missed test case from codecov #3005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3005 +/- ##
==========================================
+ Coverage 41.70% 42.53% +0.83%
==========================================
Files 899 899
Lines 56387 56454 +67
==========================================
+ Hits 23516 24014 +498
+ Misses 32871 32440 -431
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gnunicorn
approved these changes
May 26, 2025
native/acter/api.rsh
Outdated
Comment on lines
1959
to
1979
| /// update builder | ||
| fn update_builder() -> Result<CommentUpdateBuilder>; | ||
|
|
||
| /// replace the current task with one with the latest state | ||
| fn refresh() -> Future<Result<Comment>>; | ||
|
|
||
| /// whether or not this user can redact this item | ||
| fn can_redact() -> Future<Result<bool>>; | ||
| } | ||
|
|
||
| object CommentUpdateBuilder { | ||
| /// set description text | ||
| fn content_text(body: string); | ||
|
|
||
| /// set description html text | ||
| fn content_formatted(body: string, html_body: string); | ||
|
|
||
| /// send builder update | ||
| fn send() -> Future<Result<EventId>>; | ||
| } | ||
|
|
There was a problem hiding this comment.
Our UI currently doesn't have any notion of updating comments and having updated comments (like we don't have notifications nor activities for those either), I am not sure we want to expose this API yet...
| assert_eq!(cal_events.len(), 3); | ||
| let main_event = cal_events.first().expect("main event should be available"); | ||
|
|
||
| let locations = main_event.locations(); |
|
But we will keep core module and test fn for comment update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api.rshtoo