[Accessibility support] - Empty alt attribute is now consistently supported #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifferent ways - I hasn't been true for several years
giacomo-petri
added
the
accessibility support
giacomo-petri
requested review from
WilcoFiers,
carlosapaduarte,
dd8 and
Jym77
WilcoFiers
approved these changes
Feb 6, 2025
| @@ -55,7 +55,6 @@ There are no assumptions. | |||
|
|
|||
| ### Accessibility Support | |||
|
|
|||
| - There are several popular browsers that do not treat images with an empty `alt` attribute (`alt=""`) as having a role of `presentation` but instead add the `img` element to the accessibility tree with a [semantic role][] of either `img` or `graphic`. | |||
There was a problem hiding this comment.
This has been very well supported across multiple AT/browser combinations since 2014:
https://www.powermapper.com/tests/screen-readers/labelling/img-null-alt/
dd8
approved these changes
Feb 6, 2025
Jym77
approved these changes
Feb 6, 2025
|
We're saying above "This can be merged with 1 approval". But our checks do require three approvals, and this is a change to a rule. I think three approvals still required here ... |
daniel-montalvo
approved these changes
Feb 7, 2025
daniel-montalvo
changed the title
|
Edited the description! Thanks for the catch |
|
Call for review ends on February 28th 2025. |
giacomo-petri
added
Review call 2 weeks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2273
Description:
I've removed the following accessibility support note from Image has non-empty accessible name - 23a2a8
Since it's quite few years this is no longer true.
Need for Call for Review:
This will require a 2 weeks Call for Review