Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print to default output according to verbosity #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Print to default output according to verbosity #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/manifestoo/addons_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,17 @@ def extend_from_import_odoo(self, python: str) -> None:
output = tempfile.NamedTemporaryFile(delete=False)
try:
output.close()
stderrpipe = subprocess.DEVNULL
stdoutpipe = subprocess.DEVNULL
if echo.verbosity > 0:
stderrpipe = None
if echo.verbosity > 1:
stdoutpipe = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yann-papouin Thanks for this. Makes sense overall.
Do you have a specific reason to treat stdout and stderr differently here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No specific reason :)

try:
r = subprocess.call(
[python, script.name, output.name],
stderr=subprocess.DEVNULL,
stdout=subprocess.DEVNULL,
stderr=stderrpipe,
stdout=stdoutpipe,
env=os.environ,
)
except FileNotFoundError:
Expand Down
Loading