-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD set command to apply settings #51
base: master
Are you sure you want to change the base?
Conversation
please @mourad-ehm @PierrickBrun could you have a look here ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds useful.
Roadmap improvements that come to mind would be an option to list existing settings with their description and current value, as well as a possibility to provide settings on the command line.
This will need tests and documentation update before merging.
setup.py
Outdated
@@ -45,5 +45,6 @@ | |||
click-odoo-initdb=click_odoo_contrib.initdb:main | |||
click-odoo-backupdb=click_odoo_contrib.backupdb:main | |||
click-odoo-makepot=click_odoo_contrib.makepot:main | |||
click-odoo-set=click_odoo_contrib.set:main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command name is a bit terse. I suppose it should mention what it sets, somehow.
Thanks for your feedback Stéphane. |
To be clear I'm not asking you to implement the roadmap ideas :) Only tests and doc update are required. BTW, you can type "pre-commit install" once at the repo root on your local machine to auto check / fix the black/isort/flake8 issues on each commit. |
24cadc5
to
a558918
Compare
Hi @sbidoul do you have suggestions (existing test script or any) to make a useful test for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (no functional test)
It would be really nice to read a JSON/YAML file (optionally) and do merges on multiple sources. This is useful as I might build a config tree for different Odoo runtimes. Some examples:
|
@sbidoul