Add PV support to the executor statefulset #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnaut
approved these changes
Jun 17, 2024
jjoyce0510
reviewed
Jun 17, 2024
| existingClaim: "" | ||
| mountPath: /tmp/datahub | ||
| size: 100Gi | ||
| # storageClass: "-" |
There was a problem hiding this comment.
what is an example value here?
do you thik their engineers will understand how to correctly configure to store on say S3?
There was a problem hiding this comment.
if that parameter is omitted, this will use default storage class configured in their cluster. I'd not go with S3 volumes, because that path is used by ingestions to store venv and logs. We actually use similar config in ECS (cloudformation).
Alternatively, they can mount it under a different path (e.g. /memory-profiles), and then use S3 volumes, but I'm not sure their kube cluster supports it. Usually EBS gp2/gp3 is the only supported volume type in AWS deployments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled. PV is disabled by defAult.
@darnaut @eboneil @jjoyce0510