Allow switching between Deployment and StatefulSet controllers

acryldata · Oct 2, 2024 · 7aed1e6 · 7aed1e6
1 parent 0191b9a
commit 7aed1e6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/charts/datahub-executor-worker/Chart.yaml b/charts/datahub-executor-worker/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: datahub-executor-worker
 description: A Helm chart for datahub-executor-worker
 type: application
-version: 0.0.7
+version: 0.0.8
 appVersion: 0.0.1
 maintainers:
   - name: DataHub

diff --git a/...xecutor-worker/templates/statefulset.yaml → ...b-executor-worker/templates/workload.yaml b/...xecutor-worker/templates/statefulset.yaml → ...b-executor-worker/templates/workload.yaml
@@ -1,5 +1,5 @@
 apiVersion: apps/v1
-kind: StatefulSet
+kind: {{ .Values.workloadKind }}
 metadata:
   name: {{ include "datahub-executor-worker.fullname" . }}
   labels:
@@ -13,6 +13,9 @@ spec:
     matchLabels:
       {{- include "datahub-executor-worker.selectorLabels" . | nindent 6 }}
   {{- if .Values.persistentVolume.enabled }}
+  {{- if ne .Values.workloadKind "StatefulSet" }}
+  {{- fail "workloadKind must be set to StatefulSet when persistent volume is enabled" }}
+  {{- end }}
   volumeClaimTemplates:
     - metadata:
         {{- with .Values.persistentVolume.annotations }}

diff --git a/charts/datahub-executor-worker/values.yaml b/charts/datahub-executor-worker/values.yaml
@@ -12,6 +12,8 @@ global:
       monitors:
         max_workers: 10
 
+workloadKind: Deployment
+
 replicaCount: 1
 
 revisionHistoryLimit: 1
@@ -93,6 +95,7 @@ readinessProbe:
   timeoutSeconds: 5
 
 persistentVolume:
+  # Requires workloadKind: StatefulSet
   enabled: false
   accessModes:
     - ReadWriteOnce