Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace ethers Event with Log #1830

Merged
merged 5 commits into from
Sep 24, 2024
Merged

refactor: Replace ethers Event with Log #1830

merged 5 commits into from
Sep 24, 2024

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Sep 20, 2024

This follows a similar change in the SDK, with the same motivations. Reverting to Log instead of Event does not sacrifice any functionality but makes it easier to migrate away from ethers v5.

@pxrl
refactor: Replace ethers Event with Log
44457b8 
This follows a similar change in the SDK, with the same motivations.
Reverting to Log instead of Event does not sacrifice any functionality
but makes it easier to migrate away from ethers v5.
@pxrl
Copy link
Contributor Author

pxrl commented Sep 20, 2024 •
edited
Loading

nb. This will currently fail until the upstream PR in the SDK is merged and a new release is produced (across-protocol/sdk#738).

Done.

@pxrl pxrl marked this pull request as ready for review September 20, 2024 21:35
@pxrl
Copy link
Contributor Author

pxrl commented Sep 20, 2024

I've tested this a bit with the validateRootBundle.ts script - it's successfully validating old bundles within the past few days OK.

@pxrl pxrl changed the title [WIP] refactor: Replace ethers Event with Log refactor: Replace ethers Event with Log Sep 20, 2024
@pxrl pxrl requested a review from bmzig September 24, 2024 12:56
nicholaspai
nicholaspai approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a simple type swap, LGTM

bmzig
bmzig approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@bmzig bmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, especially since the only fields of Event we dropped to create Log were the ones we didn't use in the first place.

@pxrl pxrl merged commit f749ca3 into master Sep 24, 2024
4 checks passed
@pxrl pxrl deleted the pxrl/event branch September 24, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholaspai nicholaspai nicholaspai approved these changes

@bmzig bmzig bmzig approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@james-a-morris james-a-morris Awaiting requested review from james-a-morris james-a-morris is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pxrl @nicholaspai @bmzig