Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: menu and footer to follow button component style practices #162

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ViksCO
Copy link
Collaborator

@ViksCO ViksCO commented Nov 12, 2024

Type of change

  • Documentation (updates to the documentation, readme or JSDoc annotations)
  • Bug fix (a non-breaking change that fixes an issue)
  • [ x ] Enhancement (improving an existing functionality like performance)
  • New feature (a non-breaking change that adds functionality)
  • [ x ] Refactoring (old API is revised and supported)
  • Chore (updates to the build process or auxiliary tools and libraries)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Related issue

Checklist

  • I have linked an issue or discussion;
  • I have updated the documentation accordingly;
  • I have added or updated tests to cover my changes;
  • I have performed a self-review of my code;
  • My code follows the style guidelines of this project;
  • My changes generate no new warnings.

@ViksCO ViksCO requested a review from leonid as a code owner November 12, 2024 09:17
@ViksCO ViksCO self-assigned this Nov 12, 2024
@ViksCO ViksCO requested a review from edikdeisling November 12, 2024 09:18
packages/ui/src/components/footer/footer.vue Show resolved Hide resolved
packages/ui/src/components/footer/footer.vue Outdated Show resolved Hide resolved
packages/ui/src/components/footer/footer.vue Show resolved Hide resolved
packages/ui/src/components/footer/public.ts Show resolved Hide resolved
packages/ui/src/components/menu/menu.ts Show resolved Hide resolved
packages/ui/src/components/menu/menu.vue Outdated Show resolved Hide resolved
@ViksCO ViksCO force-pushed the refactor/menu-and-footerr branch from d3e3b9a to 22b591b Compare November 22, 2024 13:39
@ViksCO
Copy link
Collaborator Author

ViksCO commented Nov 22, 2024

Need to fix tests

@ViksCO ViksCO force-pushed the refactor/menu-and-footerr branch from de98f96 to ce8a73e Compare November 25, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants