Debugging info for failed SUT placement #104
Open
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @danepowell. I'm gonna chew on this a little bit. I'm wondering if more of this could be validated before creating the fixture. 🤔 |
|
Not that this would have changed the outcome at all, but just for posterity, the correct package type was There's definitely still value in adding debugging info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a little confused trying to integrate ORCA with Drupal Environment Detector (acquia/drupal-environment-detector#9) because ORCA assumed it was a Drupal module and threw an exception "Failed to place SUT at correct path", which by itself isn't very helpful in diagnosing the issue.
It turned out to be pretty simple, I just need to change the SUT package type, but the exception could do a better job of leading people to that info.
See an example of the output of this patch: https://travis-ci.com/github/acquia/drupal-environment-detector/jobs/377032879#L2373