-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI-1377 Delay API lookup of application by ID #1781
Conversation
@mglaman are you able to fix the test cases for this? |
@danepowell yeah, it fell off my radar, thanks for the ping! |
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1781/acli.phar
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1781 +/- ##
=========================================
Coverage 92.22% 92.22%
Complexity 1817 1817
=========================================
Files 121 121
Lines 6813 6814 +1
=========================================
+ Hits 6283 6284 +1
Misses 530 530 ☔ View full report in Codecov by Sentry. |
sorry for commit spam, couldn't run tests locally |
Thanks for the PR! |
Motivation
Fixes CLI-1377
Proposed changes
We are passing destination URLs and other required parameters to an application which isn't accessible over the API and doesn't need to be given the provided params
Alternatives considered
Fake the ID
Testing steps
./bin/acli ckc