Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1377 Delay API lookup of application by ID #1781

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

mglaman
Copy link
Contributor

@mglaman mglaman commented Aug 19, 2024

Motivation
Fixes CLI-1377

Proposed changes
We are passing destination URLs and other required parameters to an application which isn't accessible over the API and doesn't need to be given the provided params

Alternatives considered
Fake the ID

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

@danepowell
Copy link
Contributor

@mglaman are you able to fix the test cases for this?

@mglaman
Copy link
Contributor Author

mglaman commented Sep 5, 2024

@danepowell yeah, it fell off my radar, thanks for the ping!

Copy link

github-actions bot commented Sep 5, 2024

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1781/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1781/acli.phar
chmod +x acli.phar

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (9960580) to head (35fbec0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1781   +/-   ##
=========================================
  Coverage     92.22%   92.22%           
  Complexity     1817     1817           
=========================================
  Files           121      121           
  Lines          6813     6814    +1     
=========================================
+ Hits           6283     6284    +1     
  Misses          530      530           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mglaman
Copy link
Contributor Author

mglaman commented Sep 5, 2024

sorry for commit spam, couldn't run tests locally

@danepowell danepowell merged commit f4fa8e7 into acquia:main Sep 9, 2024
13 of 14 checks passed
@danepowell
Copy link
Contributor

Thanks for the PR!

@mglaman mglaman deleted the patch-1 branch September 9, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants