Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1370: PHP warning in pull:db when backup fails #1776

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Aug 2, 2024

Motivation

Fixes warnings when a backup (or any other Cloud API task) fails

Proposed changes

Check the notification response to make sure the task completed successfully

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

@danepowell danepowell added the bug Something isn't working label Aug 2, 2024
@danepowell danepowell marked this pull request as ready for review August 2, 2024 15:33
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.02%. Comparing base (938f87b) to head (a6bfa06).

Files Patch % Lines
src/Command/Env/EnvMirrorCommand.php 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1776      +/-   ##
============================================
- Coverage     92.02%   92.02%   -0.01%     
- Complexity     1819     1826       +7     
============================================
  Files           121      121              
  Lines          6838     6844       +6     
============================================
+ Hits           6293     6298       +5     
- Misses          545      546       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 2, 2024

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1776/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1776/acli.phar
chmod +x acli.phar

@danepowell danepowell merged commit 402fbef into acquia:main Aug 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant