Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1307| Integration tests #1773

Merged
merged 5 commits into from
Aug 6, 2024
Merged

CLI-1307| Integration tests #1773

merged 5 commits into from
Aug 6, 2024

Conversation

ashu-taide
Copy link
Contributor

Motivation
Integration tests that will execute on ubuntu that will simulate how user uses acli on ubuntu

Proposed changes
Integration tests added in

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)
  4. install python3
  5. on macos rm ~/.acquia/cloud_api.conf
  6. on linux rm /root/.config/acquia/cloud_api.conf
  7. export APPLICATION_UUID="appuuid"
  8. export APPLICATION_NAME="appname"
  9. export ACLI_AUTH_TOKEN="authtoken"
  10. export ACLI_AUTH_SECRET="authsecret"
  11. Run python3 -m unittest discover -s tests/integration/testcases in the cli directory

@ashu-taide ashu-taide marked this pull request as draft July 25, 2024 09:34
Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1773/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1773/acli.phar
chmod +x acli.phar

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (12e1dc5) to head (d17389f).
Report is 30 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1773      +/-   ##
============================================
+ Coverage     91.73%   92.02%   +0.29%     
- Complexity     1810     1819       +9     
============================================
  Files           121      121              
  Lines          6506     6838     +332     
============================================
+ Hits           5968     6293     +325     
- Misses          538      545       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell
Copy link
Contributor

@ashu-taide this looks great, thanks. Anything you need before I formally approve and merge this?

@danepowell danepowell marked this pull request as ready for review August 6, 2024 21:30
@danepowell danepowell merged commit 5dccb36 into acquia:main Aug 6, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants