Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1362: [push:db] mysqldump failure not surfaced #1770

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Jul 18, 2024

Turns out we aren't the first ones to have this problem: drush-ops/drush#3816

If Drush does it this way, it's good enough for me! 😄

Testing steps:

  • Set max_allowed_packet extremely low, or import a db with huge row sizes
  • Run push:db -vvv

Before this PR, see that the push continues past the local dump despite an error about packet size. After this error, see that the push stops with the following exception:

In CommandBase.php line 1703:
                                                  
  [Acquia\Cli\Exception\AcquiaCliException]       
  Unable to create a dump of the local database.  

@danepowell danepowell added the bug Something isn't working label Jul 18, 2024
Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1770/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1770/acli.phar
chmod +x acli.phar

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (56d0139) to head (b94a3ae).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1770      +/-   ##
============================================
+ Coverage     91.99%   92.02%   +0.02%     
  Complexity     1818     1818              
============================================
  Files           121      121              
  Lines          6834     6834              
============================================
+ Hits           6287     6289       +2     
+ Misses          547      545       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell marked this pull request as ready for review July 19, 2024 15:51
@danepowell danepowell merged commit 94b1e90 into acquia:main Jul 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant