Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1328: Pull command asks for environment twice #1732

Merged
merged 7 commits into from
Apr 24, 2024

Conversation

danepowell
Copy link
Contributor

No description provided.

@danepowell danepowell added the bug Something isn't working label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (c8b517f) to head (7e9a4b4).

❗ Current head 7e9a4b4 differs from pull request most recent head 4a2dd61. Consider uploading reports for the commit 4a2dd61 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1732      +/-   ##
============================================
+ Coverage     91.46%   91.64%   +0.18%     
+ Complexity     1809     1808       -1     
============================================
  Files           121      121              
  Lines          6478     6474       -4     
============================================
+ Hits           5925     5933       +8     
+ Misses          553      541      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 22, 2024

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1732/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1732/acli.phar
chmod +x acli.phar

@danepowell danepowell marked this pull request as ready for review April 22, 2024 23:40
@danepowell danepowell changed the title CLI-1328: Pull commands ask for environment twice CLI-1328: Pull command asks for environment twice Apr 22, 2024
@anavarre
Copy link
Contributor

@ashu-taide this is where Dane is fixing the issue you've been seeing in Cloud IDE. Feel free to try out the above Phar file and report back.

@ashu-taide
Copy link
Contributor

ashu_hibernation_operator:~/project $ cd /home/ide
ashu_hibernation_operator:~ $ ls
ama_source  configs  mysql-data  project  welcome
ashu_hibernation_operator:~ $ curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1732/acli.phar
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   326    0   326    0     0   8150      0 --:--:-- --:--:-- --:--:--  8150

ashu_hibernation_operator:~ $ chmod +x acli.phar
ashu_hibernation_operator:~ $ cd project/
ashu_hibernation_operator:~/project $ /home/ide/acli.phar
/home/ide/acli.phar: line 1: syntax error near unexpected token `newline'
/home/ide/acli.phar: line 1: `<?xml version="1.0" encoding="UTF-8"?>'
ashu_hibernation_operator:~/project $ /home/ide/acli.phar --help
/home/ide/acli.phar: line 1: syntax error near unexpected token `newline'
/home/ide/acli.phar: line 1: `<?xml version="1.0" encoding="UTF-8"?>'
ashu_hibernation_operator:~/project $ /home/ide/acli.phar auth:login
/home/ide/acli.phar: line 1: syntax error near unexpected token `newline'
/home/ide/acli.phar: line 1: `<?xml version="1.0" encoding="UTF-8"?>'
ashu_hibernation_operator:~/project $ 

I keep getting this error, am I installing the acli incorrectly in the IDE

@anavarre
Copy link
Contributor

Something looks off indeed.

❯ curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1732/acli.phar
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   294    0   294    0     0    674      0 --:--:-- --:--:-- --:--:--   675
❯ chmod +x acli.phar
❯ ./acli.phar
./acli.phar: line 1: syntax error near unexpected token `newline'
./acli.phar: line 1: `<?xml version="1.0" encoding="UTF-8"?>'

@danepowell
Copy link
Contributor Author

Sorry! S3 uploads are a new thing, and unfortunately one of the limitations of GitHub Actions is that this workflow is impossible to test before it actually runs. I think I fixed it.

@anavarre
Copy link
Contributor

Great! Could you please try again @ashu-taide ? I pulled the Phar file again and ACLI bootstraps correctly now.

@ashu-taide
Copy link
Contributor

the pull command did not ask for environment twice, so working as expected
Now checking for any regressions in other commands

@danepowell danepowell enabled auto-merge (squash) April 24, 2024 15:08
@danepowell danepowell merged commit baa7bea into acquia:main Apr 24, 2024
10 checks passed
@danepowell danepowell deleted the CLI-1328 branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants